-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Enable aspects for remaining resources. #41
Comments
Ref: https://github.com/cdklabs/cdk-watchful/blob/main/src/aspect.ts The concept of `MyMonitoringOptions` for every monitoring is needed because `Omit` is not supported by JSII. Please refer this issue and the comment on the linked PR for the way to handle that. aws/jsii#1707 Opened an issue to add aspects for other left-out resources: #41
Would be awesome to see! Is there any inherent complexity one should think about when implementing aspects for these particular resources? I assume there was a reason it's not yet implemented. |
This comment was marked as outdated.
This comment was marked as outdated.
So these have not been implemented because of how the underlying facade implementation of the monitoring is done. For example
|
Thanks for the insight @ayush987goyal - that roughly matches what I had observed from glancing over it.
|
|
I mentioned this in #120, but I'm personally very much in favor of breaking ECS down into it's component parts for monitoring and not trying to work with the L2/L3 patterns. |
Enable scope monitoring with aspects for the following remaining resources
The text was updated successfully, but these errors were encountered: