feat: Add scope monitoring with aspects #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions <[email protected]>
echeung-amzn
reviewed
Mar 2, 2022
voho
reviewed
Mar 2, 2022
Signed-off-by: github-actions <[email protected]>
ayush987goyal
requested review from
echeung-amzn and
voho
and removed request for
voho
voho
approved these changes
Mar 4, 2022
echeung-amzn
reviewed
Mar 4, 2022
ayush987goyal
added a commit
that referenced
this pull request
Mar 5, 2022
This reverts commit b514e71.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/cdklabs/cdk-watchful/blob/main/src/aspect.ts
The concept of
MyMonitoringOptionsfor every monitoring is needed becauseOmitis not supported by JSII. Please refer this issue and the comment on the linked PR for the way to handle that.aws/jsii#1707
Opened an issue to add aspects for other left-out resources: #41