Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/python 3.12 upgrade #1996

Merged
merged 33 commits into from
Dec 4, 2024
Merged

Chore/python 3.12 upgrade #1996

merged 33 commits into from
Dec 4, 2024

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Nov 15, 2024

Summary | Résumé

Upgrade to Python 3.12

Only code changes needed were in the tests 🎉

Test instructions | Instructions pour tester la modification

  • run with any api (or run review environment)
  • can use new make run-gunicorn target to test gunicorn locally.

Copy link

@sastels sastels marked this pull request as ready for review December 2, 2024 19:07
@sastels sastels marked this pull request as draft December 2, 2024 19:07
.PHONY: run-gunicorn
run-gunicorn:
PORT=6012 poetry run gunicorn -c gunicorn_config.py application

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added to help us test gunicorn locally

@sastels sastels marked this pull request as ready for review December 3, 2024 16:29
Copy link
Contributor

@P0NDER0SA P0NDER0SA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sastels ! engage!

@sastels sastels merged commit 992103f into main Dec 4, 2024
11 checks passed
@sastels sastels deleted the chore/python-3.12 branch December 4, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants