Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade admin to Python 3.12 #463

Closed
4 of 5 tasks
sastels opened this issue Nov 25, 2024 · 9 comments
Closed
4 of 5 tasks

Upgrade admin to Python 3.12 #463

sastels opened this issue Nov 25, 2024 · 9 comments
Assignees
Labels
Reliability Task related to reliability. Security | Sécurité Tech Debt An issue targeting an identified technical debt

Comments

@sastels
Copy link

sastels commented Nov 25, 2024

Description

As a software developer working on GCNotify stack,
I want the Python stack to be upgraded at latest supported version,
So that I can leverage the latest features of the language and better/safer code.

As a system ops working on GCNotify stack,
I want the Python stack to be upgraded at latest supported version,
So that I can leverage the latest performance improvement
And process notifications faster.

WHY are we building?

To get latest performance improvements, features and security updates of the Python language/runtime.

WHAT are we building?

Upgrade the stack to the latest possible version of Python. A few considerations:

  • It is possible that we cannot upgrade to the latest of the latest (3.12 at the time of this writing for the stable version), as this might be blocked by a dependency library that did not release a version supporting the latest. For example, we might have to upgrade from version 3.10 to version 3.11, and wait a bit longer to migrate to version 3.12.
  • The lambdas might have additional considerations that might limit the possible maximum Python version we can use, such as supported runtime and also monitoring libraries that need to support that environment (such as New Relic). Consider doing this work in Upgrade lambda and New Relic to latest supported version #354 .

VALUE created by our solution

Better performance, security and reliability.

Acceptance Criteria

  • Admin running on Python 3.12.
  • test locally
  • test on dev
  • document in tricks and tips how we can deploy branches to dev

QA Steps

  • poke around in admin
@sastels sastels added Reliability Task related to reliability. Security | Sécurité Tech Debt An issue targeting an identified technical debt labels Nov 25, 2024
@sastels sastels self-assigned this Nov 25, 2024
@sastels sastels changed the title Copy of Upgrade document-download-api to Python 3.12 Upgrade admin to Python 3.12 Nov 25, 2024
@sastels
Copy link
Author

sastels commented Nov 26, 2024

@jimleroyer
Copy link
Member

There are some tests to fixed, following the upgrade to Python 3.12 and due to its stricter type check. Steve is on a quest to fix these.

@sastels
Copy link
Author

sastels commented Nov 27, 2024

all tests passing locally and in CI

@sastels
Copy link
Author

sastels commented Nov 28, 2024

Working locally (devcontainer) with other apps.

@sastels
Copy link
Author

sastels commented Dec 3, 2024

Ready for review
cds-snc/notification-admin#1996

@P0NDER0SA
Copy link

Pond will review

@P0NDER0SA
Copy link

Looks ok! Steve can merge this and move to QA

@sastels
Copy link
Author

sastels commented Dec 4, 2024

in staging, looks good

@P0NDER0SA P0NDER0SA self-assigned this Dec 5, 2024
@P0NDER0SA
Copy link

QA'ed!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reliability Task related to reliability. Security | Sécurité Tech Debt An issue targeting an identified technical debt
Projects
None yet
Development

No branches or pull requests

3 participants