Close CefSharp.BrowserSubprocess.exe if parent process exits #2375

joaompneves · 2018-04-26T10:32:19Z

Following the issue #2359 here is the "solution".

I tested this solution making the following changes in CefSharp.Wpf.Example\Views\BrowserTabView.xaml.cs:

browser.RenderProcessMessageHandler = new RenderProcessMessageHandler();

browser.FrameLoadStart += (sender, args) => {
    browser.Dispatcher.BeginInvoke((Action) (() => {
        Thread.Sleep(10);
        Environment.Exit(0);
    }));
};

AppVeyorBot · 2018-04-26T10:36:57Z

✅ Build CefSharp 65.0.0-CI2580 completed (commit 04a14ebca8 by @joaompneves)

amaitland

Comments inline

amaitland · 2018-04-27T02:02:22Z

CefSharp.BrowserSubprocess/Program.cs

-            const string typePrefix = "--type=";
-            var typeArgument = args.SingleOrDefault(arg => arg.StartsWith(typePrefix));
-            var type = typeArgument.Substring(typePrefix.Length);
+            Task.Run(() => AwaitParentProcessExit(parentProcessId));


Whilst the ThreadPool won't be used in the render process, it just doesn't seem appropriate to use a vanilla Task.Run, should probably add TaskCreationOptions.LongRunning, from memory it should spawn a new Thread and a quick check on stackoverflow suggests it will.

https://stackoverflow.com/a/10298761

I though about adding that, but since this process is running mostly unmanaged code and is not using the ThreadPool, I skipped it. But its a small change, I will do it.

amaitland · 2018-04-27T02:06:44Z

CefSharp.BrowserSubprocess/Program.cs

+            {
+                //main process probably died already, bailout
+                Debug.WriteLine(e);
+                return;


What's the purpose of this return?

I assumed that the process would die by it self, but I'll remove it... its safer.

amaitland · 2018-04-27T02:18:52Z

CefSharp.BrowserSubprocess/Program.cs

+
+            Task.Delay(1000); //wait a bit before exiting
+
+            Debug.WriteLine("BrowserSubprocess shutting down forcibly.");


Should probably log to the native CEF Logging, trivial to add an wrapper method.

I just copied the same pattern that was already there.

amaitland · 2018-04-27T02:20:30Z

CefSharp/CefCustomScheme.cs

@@ -119,13 +119,12 @@ public CefCustomScheme()
        /// <returns>list of scheme objects</returns>
        public static List<CefCustomScheme> ParseCommandLineArguments(IEnumerable<string> args)
        {
-            var schemes = args.FirstOrDefault(a => a.StartsWith(CefSharpArguments.CustomSchemeArgument));
+            var schemes = args.GetArgumentValue(CefSharpArguments.CustomSchemeArgument);


Have you tested these changes?

Yes... and I even spotted an existing "bug". Some of the parameters sent to the process are duplicated, that's why the FirstOrDefault works but not not SIngleOrDefault.

Which paramaters are duplicated?

Those defined in CefSharpArguments

Interesting, thanks

AppVeyorBot · 2018-04-27T10:00:09Z

✅ Build CefSharp 65.0.0-CI2591 completed (commit 352ba2bbda by @joaompneves)

AppVeyorBot · 2018-04-27T10:04:19Z

✅ Build CefSharp 65.0.0-CI2592 completed (commit 945f2381b4 by @joaompneves)

Improve command line parsing Partial import of changes from #2375

amaitland · 2018-04-30T04:27:21Z

I don't have time to properly review this before the 65.0.0-pre01 release which will be out shortly.

I've manually cherry picked some pieces that are included in commit f2fcbf0

The process id will always be passed through and I've updated the command line parsing. This should give anyone wishing to try this feature out the ability to create their own BrowserSubprocess with minimal effort and include the Task that waits for the parent to exit.

When it comes time to merge this I'll resolve the conflicts.

kronic · 2018-05-28T09:26:38Z

CefSharp.BrowserSubprocess/Program.cs

-            const string typePrefix = "--type=";
-            var typeArgument = args.SingleOrDefault(arg => arg.StartsWith(typePrefix));
-            var type = typeArgument.Substring(typePrefix.Length);
+            Task.Factory.StartNew(() => AwaitParentProcessExit(parentProcessId), TaskCreationOptions.LongRunning);


Does not take a thread

var parentProcess = Process.GetProcessById(parentProcessId) if(parentProcess != null) { parentProcess.EnableRaisingEvents = true; parentProcess.Exited += (o,a) => { Debug.WriteLine("BrowserSubprocess shutting down forcibly."); Environment.Exit(0); } }

kronic · 2018-05-28T09:38:51Z

CefSharp.BrowserSubprocess/Program.cs

+                Debug.WriteLine(e);
+            }
+
+            Task.Delay(1000); //wait a bit before exiting


await Task.Delay(1000);

AppVeyorBot · 2018-06-06T07:49:01Z

✅ Build CefSharp 66.0.0-CI2630 completed (commit c9683e79f9 by @joaompneves)

AppVeyorBot · 2018-06-06T08:06:25Z

❌ Build CefSharp 66.0.0-CI2631 failed (commit a29c000042 by @joaompneves)

AppVeyorBot · 2018-06-06T08:12:32Z

✅ Build CefSharp 66.0.0-CI2632 completed (commit 4af076c88c by @joaompneves)

…k to monitor parent if command line arg present Follow up to #2375

* Close cefsharp subprocess if main process dies * Code review * Await before exiting * Update Program.cs

…k to monitor parent if command line arg present Follow up to #2375

Close cefsharp subprocess if main process dies

d957e36

amaitland requested changes Apr 27, 2018

View reviewed changes

joaompneves and others added 2 commits April 27, 2018 10:53

Code review

520d5fd

Merge branch 'master' into CloseSubProcessOnMainFailure

b8ae9dc

amaitland added a commit that referenced this pull request Apr 30, 2018

Always pass through Process Id to subprocess

f2fcbf0

Improve command line parsing Partial import of changes from #2375

amaitland added a commit that referenced this pull request Apr 30, 2018

Always pass through Process Id to subprocess

a8ff890

Improve command line parsing Partial import of changes from #2375

amaitland changed the title ~~Close cefsharp subprocess when main process dies~~ Close CefSharp.BrowserSubprocess.exe if parent process exits May 2, 2018

kronic reviewed May 28, 2018

View reviewed changes

Merge branch 'master' into CloseSubProcessOnMainFailure

a97189a

Await before exiting

d8dba77

Update Program.cs

8b3ca42

amaitland merged commit 274e841 into cefsharp:master Jun 9, 2018

amaitland mentioned this pull request Jun 10, 2018

CefSharp.BrowserSubprocess.exe left running after parent process exit #2359

Closed

amaitland added a commit that referenced this pull request Jun 11, 2018

CefSharpSettings.SubprocessExitIfParentProcessClosed - only spawn tas…

e4535ab

…k to monitor parent if command line arg present Follow up to #2375

amaitland pushed a commit that referenced this pull request Jun 20, 2018

Close CefSharp.BrowserSubprocess.exe if parent process exits (#2375)

4f9c95c

* Close cefsharp subprocess if main process dies * Code review * Await before exiting * Update Program.cs

amaitland added a commit that referenced this pull request Jun 20, 2018

CefSharpSettings.SubprocessExitIfParentProcessClosed - only spawn tas…

130c378

…k to monitor parent if command line arg present Follow up to #2375

joaompneves mentioned this pull request May 3, 2019

Kill sub process to avoid hanging forever #2756

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Close CefSharp.BrowserSubprocess.exe if parent process exits #2375

Close CefSharp.BrowserSubprocess.exe if parent process exits #2375

joaompneves commented Apr 26, 2018 •

edited

Loading

AppVeyorBot commented Apr 26, 2018

amaitland left a comment

amaitland Apr 27, 2018

joaompneves Apr 27, 2018

amaitland Apr 27, 2018

joaompneves Apr 27, 2018

amaitland Apr 27, 2018

joaompneves Apr 27, 2018

amaitland Apr 27, 2018

joaompneves Apr 27, 2018

amaitland Apr 27, 2018

joaompneves Apr 27, 2018

amaitland Apr 27, 2018

AppVeyorBot commented Apr 27, 2018

AppVeyorBot commented Apr 27, 2018

amaitland commented Apr 30, 2018

kronic May 28, 2018

kronic May 28, 2018

AppVeyorBot commented Jun 6, 2018

AppVeyorBot commented Jun 6, 2018

AppVeyorBot commented Jun 6, 2018


		Task.Delay(1000); //wait a bit before exiting

		Debug.WriteLine("BrowserSubprocess shutting down forcibly.");

Close CefSharp.BrowserSubprocess.exe if parent process exits #2375

Close CefSharp.BrowserSubprocess.exe if parent process exits #2375

Conversation

joaompneves commented Apr 26, 2018 • edited Loading

AppVeyorBot commented Apr 26, 2018

amaitland left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AppVeyorBot commented Apr 27, 2018

AppVeyorBot commented Apr 27, 2018

amaitland commented Apr 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AppVeyorBot commented Jun 6, 2018

AppVeyorBot commented Jun 6, 2018

AppVeyorBot commented Jun 6, 2018

joaompneves commented Apr 26, 2018 •

edited

Loading