Upgrade to Wagtail 3.0.3 #7423
Merged
Upgrade to Wagtail 3.0.3 #7423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chosak
force-pushed
the
upgrade/wagtail
branch
from
c991948 to
d2f0bd0
Compare
willbarton
reviewed
Jan 9, 2023
chosak
force-pushed
the
upgrade/wagtail
branch
from
d2f0bd0 to
141c64d
Compare
This commit updates the imports of Wagtail modules to be compatible with the new organization in Wagtail 3.x. These changes are the result of running Wagtail's updatemodulepaths command, as documented: https://docs.wagtail.org/en/latest/releases/3.0.html#changes-to-module-paths
StreamFieldPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types
ImageChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types
DocumentChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types
SnippetChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types
PageChooserPanel has been (mostly) deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types
In Wagtail 2.x, the second positional argument to FieldPanel was its heading, but starting in 3.x you need to specify it as a keyword argument (`heading="whatever"`).
In Wagtail 3.0, PageRevision models have a content field, not a content_json field.
chosak
force-pushed
the
upgrade/wagtail-3.0.3
branch
from
1b6cd4d to
cd5e188
Compare
In Cypress tests we check for block visibility using
.should('be.visible')
but this assumes that the block is visible within the browser screen
dimensions. In Wagtail 3 the admin UI changes significantly, and the
spacing changes mean that some blocks may be off screen.
This commit adds
.scrollIntoView()
before checking whether a block is visible.
In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates our custom migration utils to support that change.
In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates the places in our code where we referenced that field.
|
@anselmbradford @willbarton all tests pass against this PR now; the only thing that fails is Python coverage but those failures are against infrequently used management commands that didn't have tests before. |
willbarton
approved these changes
Jan 12, 2023
chosak
added a commit
that referenced
this pull request
Jan 24, 2023
* Bump Wagtail version from 2.16.3 to 3.0.3 * Update Wagtail module paths for 3.x This commit updates the imports of Wagtail modules to be compatible with the new organization in Wagtail 3.x. These changes are the result of running Wagtail's updatemodulepaths command, as documented: https://docs.wagtail.org/en/latest/releases/3.0.html#changes-to-module-paths * Use FieldPanel instead of StreamFieldPanel StreamFieldPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of ImageChooserPanel ImageChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of DocumentChooserPanel DocumentChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of SnippetChooserPanel SnippetChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of PageChooserPanel PageChooserPanel has been (mostly) deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Fix FieldPanel usage for Wagtail 3.x In Wagtail 2.x, the second positional argument to FieldPanel was its heading, but starting in 3.x you need to specify it as a keyword argument (`heading="whatever"`). * Update indexed field on IndexedPageRevision In Wagtail 3.0, PageRevision models have a content field, not a content_json field. * Workaround for fbjs global undefined issue (#7446) * Scroll to blocks in Cypress tests In Cypress tests we check for block visibility using .should('be.visible') but this assumes that the block is visible within the browser screen dimensions. In Wagtail 3 the admin UI changes significantly, and the spacing changes mean that some blocks may be off screen. This commit adds .scrollIntoView() before checking whether a block is visible. * Update migration utils for content JSONField In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates our custom migration utils to support that change. * Update uses of PageRevision content field In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates the places in our code where we referenced that field. * Avoid unsafe chaining of Cypress functions https://docs.cypress.io/api/commands/scrollintoview Co-authored-by: Ans <[email protected]>
chosak
added a commit
that referenced
this pull request
Feb 1, 2023
* Bump Wagtail version from 2.16.3 to 3.0.3 * Update Wagtail module paths for 3.x This commit updates the imports of Wagtail modules to be compatible with the new organization in Wagtail 3.x. These changes are the result of running Wagtail's updatemodulepaths command, as documented: https://docs.wagtail.org/en/latest/releases/3.0.html#changes-to-module-paths * Use FieldPanel instead of StreamFieldPanel StreamFieldPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of ImageChooserPanel ImageChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of DocumentChooserPanel DocumentChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of SnippetChooserPanel SnippetChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of PageChooserPanel PageChooserPanel has been (mostly) deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Fix FieldPanel usage for Wagtail 3.x In Wagtail 2.x, the second positional argument to FieldPanel was its heading, but starting in 3.x you need to specify it as a keyword argument (`heading="whatever"`). * Update indexed field on IndexedPageRevision In Wagtail 3.0, PageRevision models have a content field, not a content_json field. * Workaround for fbjs global undefined issue (#7446) * Scroll to blocks in Cypress tests In Cypress tests we check for block visibility using .should('be.visible') but this assumes that the block is visible within the browser screen dimensions. In Wagtail 3 the admin UI changes significantly, and the spacing changes mean that some blocks may be off screen. This commit adds .scrollIntoView() before checking whether a block is visible. * Update migration utils for content JSONField In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates our custom migration utils to support that change. * Update uses of PageRevision content field In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates the places in our code where we referenced that field. * Avoid unsafe chaining of Cypress functions https://docs.cypress.io/api/commands/scrollintoview Co-authored-by: Ans <[email protected]>
willbarton
pushed a commit
that referenced
this pull request
Feb 10, 2023
* Bump Wagtail version from 2.16.3 to 3.0.3 * Update Wagtail module paths for 3.x This commit updates the imports of Wagtail modules to be compatible with the new organization in Wagtail 3.x. These changes are the result of running Wagtail's updatemodulepaths command, as documented: https://docs.wagtail.org/en/latest/releases/3.0.html#changes-to-module-paths * Use FieldPanel instead of StreamFieldPanel StreamFieldPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of ImageChooserPanel ImageChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of DocumentChooserPanel DocumentChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of SnippetChooserPanel SnippetChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of PageChooserPanel PageChooserPanel has been (mostly) deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Fix FieldPanel usage for Wagtail 3.x In Wagtail 2.x, the second positional argument to FieldPanel was its heading, but starting in 3.x you need to specify it as a keyword argument (`heading="whatever"`). * Update indexed field on IndexedPageRevision In Wagtail 3.0, PageRevision models have a content field, not a content_json field. * Workaround for fbjs global undefined issue (#7446) * Scroll to blocks in Cypress tests In Cypress tests we check for block visibility using .should('be.visible') but this assumes that the block is visible within the browser screen dimensions. In Wagtail 3 the admin UI changes significantly, and the spacing changes mean that some blocks may be off screen. This commit adds .scrollIntoView() before checking whether a block is visible. * Update migration utils for content JSONField In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates our custom migration utils to support that change. * Update uses of PageRevision content field In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates the places in our code where we referenced that field. * Avoid unsafe chaining of Cypress functions https://docs.cypress.io/api/commands/scrollintoview Co-authored-by: Ans <[email protected]>
willbarton
pushed a commit
that referenced
this pull request
Feb 13, 2023
* Bump Wagtail version from 2.16.3 to 3.0.3 * Update Wagtail module paths for 3.x This commit updates the imports of Wagtail modules to be compatible with the new organization in Wagtail 3.x. These changes are the result of running Wagtail's updatemodulepaths command, as documented: https://docs.wagtail.org/en/latest/releases/3.0.html#changes-to-module-paths * Use FieldPanel instead of StreamFieldPanel StreamFieldPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of ImageChooserPanel ImageChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of DocumentChooserPanel DocumentChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of SnippetChooserPanel SnippetChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of PageChooserPanel PageChooserPanel has been (mostly) deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Fix FieldPanel usage for Wagtail 3.x In Wagtail 2.x, the second positional argument to FieldPanel was its heading, but starting in 3.x you need to specify it as a keyword argument (`heading="whatever"`). * Update indexed field on IndexedPageRevision In Wagtail 3.0, PageRevision models have a content field, not a content_json field. * Workaround for fbjs global undefined issue (#7446) * Scroll to blocks in Cypress tests In Cypress tests we check for block visibility using .should('be.visible') but this assumes that the block is visible within the browser screen dimensions. In Wagtail 3 the admin UI changes significantly, and the spacing changes mean that some blocks may be off screen. This commit adds .scrollIntoView() before checking whether a block is visible. * Update migration utils for content JSONField In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates our custom migration utils to support that change. * Update uses of PageRevision content field In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates the places in our code where we referenced that field. * Avoid unsafe chaining of Cypress functions https://docs.cypress.io/api/commands/scrollintoview Co-authored-by: Ans <[email protected]>
chosak
added a commit
that referenced
this pull request
Feb 15, 2023
* Bump Wagtail version from 2.16.3 to 3.0.3 * Update Wagtail module paths for 3.x This commit updates the imports of Wagtail modules to be compatible with the new organization in Wagtail 3.x. These changes are the result of running Wagtail's updatemodulepaths command, as documented: https://docs.wagtail.org/en/latest/releases/3.0.html#changes-to-module-paths * Use FieldPanel instead of StreamFieldPanel StreamFieldPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of ImageChooserPanel ImageChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of DocumentChooserPanel DocumentChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of SnippetChooserPanel SnippetChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of PageChooserPanel PageChooserPanel has been (mostly) deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Fix FieldPanel usage for Wagtail 3.x In Wagtail 2.x, the second positional argument to FieldPanel was its heading, but starting in 3.x you need to specify it as a keyword argument (`heading="whatever"`). * Update indexed field on IndexedPageRevision In Wagtail 3.0, PageRevision models have a content field, not a content_json field. * Workaround for fbjs global undefined issue (#7446) * Scroll to blocks in Cypress tests In Cypress tests we check for block visibility using .should('be.visible') but this assumes that the block is visible within the browser screen dimensions. In Wagtail 3 the admin UI changes significantly, and the spacing changes mean that some blocks may be off screen. This commit adds .scrollIntoView() before checking whether a block is visible. * Update migration utils for content JSONField In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates our custom migration utils to support that change. * Update uses of PageRevision content field In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates the places in our code where we referenced that field. * Avoid unsafe chaining of Cypress functions https://docs.cypress.io/api/commands/scrollintoview Co-authored-by: Ans <[email protected]>
chosak
added a commit
that referenced
this pull request
Feb 15, 2023
* Bump Wagtail version from 2.16.3 to 3.0.3 * Update Wagtail module paths for 3.x This commit updates the imports of Wagtail modules to be compatible with the new organization in Wagtail 3.x. These changes are the result of running Wagtail's updatemodulepaths command, as documented: https://docs.wagtail.org/en/latest/releases/3.0.html#changes-to-module-paths * Use FieldPanel instead of StreamFieldPanel StreamFieldPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of ImageChooserPanel ImageChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of DocumentChooserPanel DocumentChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of SnippetChooserPanel SnippetChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of PageChooserPanel PageChooserPanel has been (mostly) deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Fix FieldPanel usage for Wagtail 3.x In Wagtail 2.x, the second positional argument to FieldPanel was its heading, but starting in 3.x you need to specify it as a keyword argument (`heading="whatever"`). * Update indexed field on IndexedPageRevision In Wagtail 3.0, PageRevision models have a content field, not a content_json field. * Workaround for fbjs global undefined issue (#7446) * Scroll to blocks in Cypress tests In Cypress tests we check for block visibility using .should('be.visible') but this assumes that the block is visible within the browser screen dimensions. In Wagtail 3 the admin UI changes significantly, and the spacing changes mean that some blocks may be off screen. This commit adds .scrollIntoView() before checking whether a block is visible. * Update migration utils for content JSONField In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates our custom migration utils to support that change. * Update uses of PageRevision content field In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates the places in our code where we referenced that field. * Avoid unsafe chaining of Cypress functions https://docs.cypress.io/api/commands/scrollintoview Co-authored-by: Ans <[email protected]>
chosak
added a commit
that referenced
this pull request
Mar 3, 2023
* Bump Wagtail version from 2.16.3 to 3.0.3 * Update Wagtail module paths for 3.x This commit updates the imports of Wagtail modules to be compatible with the new organization in Wagtail 3.x. These changes are the result of running Wagtail's updatemodulepaths command, as documented: https://docs.wagtail.org/en/latest/releases/3.0.html#changes-to-module-paths * Use FieldPanel instead of StreamFieldPanel StreamFieldPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of ImageChooserPanel ImageChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of DocumentChooserPanel DocumentChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of SnippetChooserPanel SnippetChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of PageChooserPanel PageChooserPanel has been (mostly) deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Fix FieldPanel usage for Wagtail 3.x In Wagtail 2.x, the second positional argument to FieldPanel was its heading, but starting in 3.x you need to specify it as a keyword argument (`heading="whatever"`). * Update indexed field on IndexedPageRevision In Wagtail 3.0, PageRevision models have a content field, not a content_json field. * Workaround for fbjs global undefined issue (#7446) * Scroll to blocks in Cypress tests In Cypress tests we check for block visibility using .should('be.visible') but this assumes that the block is visible within the browser screen dimensions. In Wagtail 3 the admin UI changes significantly, and the spacing changes mean that some blocks may be off screen. This commit adds .scrollIntoView() before checking whether a block is visible. * Update migration utils for content JSONField In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates our custom migration utils to support that change. * Update uses of PageRevision content field In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates the places in our code where we referenced that field. * Avoid unsafe chaining of Cypress functions https://docs.cypress.io/api/commands/scrollintoview Co-authored-by: Ans <[email protected]>
chosak
added a commit
that referenced
this pull request
Mar 8, 2023
* Bump Wagtail version from 2.16.3 to 3.0.3 * Update Wagtail module paths for 3.x This commit updates the imports of Wagtail modules to be compatible with the new organization in Wagtail 3.x. These changes are the result of running Wagtail's updatemodulepaths command, as documented: https://docs.wagtail.org/en/latest/releases/3.0.html#changes-to-module-paths * Use FieldPanel instead of StreamFieldPanel StreamFieldPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of ImageChooserPanel ImageChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of DocumentChooserPanel DocumentChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of SnippetChooserPanel SnippetChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of PageChooserPanel PageChooserPanel has been (mostly) deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Fix FieldPanel usage for Wagtail 3.x In Wagtail 2.x, the second positional argument to FieldPanel was its heading, but starting in 3.x you need to specify it as a keyword argument (`heading="whatever"`). * Update indexed field on IndexedPageRevision In Wagtail 3.0, PageRevision models have a content field, not a content_json field. * Workaround for fbjs global undefined issue (#7446) * Scroll to blocks in Cypress tests In Cypress tests we check for block visibility using .should('be.visible') but this assumes that the block is visible within the browser screen dimensions. In Wagtail 3 the admin UI changes significantly, and the spacing changes mean that some blocks may be off screen. This commit adds .scrollIntoView() before checking whether a block is visible. * Update migration utils for content JSONField In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates our custom migration utils to support that change. * Update uses of PageRevision content field In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates the places in our code where we referenced that field. * Avoid unsafe chaining of Cypress functions https://docs.cypress.io/api/commands/scrollintoview Co-authored-by: Ans <[email protected]>
chosak
added a commit
that referenced
this pull request
Mar 9, 2023
* Bump Wagtail version from 2.16.3 to 3.0.3 * Update Wagtail module paths for 3.x This commit updates the imports of Wagtail modules to be compatible with the new organization in Wagtail 3.x. These changes are the result of running Wagtail's updatemodulepaths command, as documented: https://docs.wagtail.org/en/latest/releases/3.0.html#changes-to-module-paths * Use FieldPanel instead of StreamFieldPanel StreamFieldPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of ImageChooserPanel ImageChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of DocumentChooserPanel DocumentChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of SnippetChooserPanel SnippetChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of PageChooserPanel PageChooserPanel has been (mostly) deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Fix FieldPanel usage for Wagtail 3.x In Wagtail 2.x, the second positional argument to FieldPanel was its heading, but starting in 3.x you need to specify it as a keyword argument (`heading="whatever"`). * Update indexed field on IndexedPageRevision In Wagtail 3.0, PageRevision models have a content field, not a content_json field. * Workaround for fbjs global undefined issue (#7446) * Scroll to blocks in Cypress tests In Cypress tests we check for block visibility using .should('be.visible') but this assumes that the block is visible within the browser screen dimensions. In Wagtail 3 the admin UI changes significantly, and the spacing changes mean that some blocks may be off screen. This commit adds .scrollIntoView() before checking whether a block is visible. * Update migration utils for content JSONField In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates our custom migration utils to support that change. * Update uses of PageRevision content field In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates the places in our code where we referenced that field. * Avoid unsafe chaining of Cypress functions https://docs.cypress.io/api/commands/scrollintoview Co-authored-by: Ans <[email protected]>
chosak
added a commit
that referenced
this pull request
Mar 9, 2023
* Bump Wagtail version from 2.16.3 to 3.0.3 * Update Wagtail module paths for 3.x This commit updates the imports of Wagtail modules to be compatible with the new organization in Wagtail 3.x. These changes are the result of running Wagtail's updatemodulepaths command, as documented: https://docs.wagtail.org/en/latest/releases/3.0.html#changes-to-module-paths * Use FieldPanel instead of StreamFieldPanel StreamFieldPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of ImageChooserPanel ImageChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of DocumentChooserPanel DocumentChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of SnippetChooserPanel SnippetChooserPanel has been deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Use FieldPanel instead of PageChooserPanel PageChooserPanel has been (mostly) deprecated in 3.0: https://docs.wagtail.org/en/latest/releases/3.0.html#removal-of-special-purpose-field-panel-types * Fix FieldPanel usage for Wagtail 3.x In Wagtail 2.x, the second positional argument to FieldPanel was its heading, but starting in 3.x you need to specify it as a keyword argument (`heading="whatever"`). * Update indexed field on IndexedPageRevision In Wagtail 3.0, PageRevision models have a content field, not a content_json field. * Workaround for fbjs global undefined issue (#7446) * Scroll to blocks in Cypress tests In Cypress tests we check for block visibility using .should('be.visible') but this assumes that the block is visible within the browser screen dimensions. In Wagtail 3 the admin UI changes significantly, and the spacing changes mean that some blocks may be off screen. This commit adds .scrollIntoView() before checking whether a block is visible. * Update migration utils for content JSONField In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates our custom migration utils to support that change. * Update uses of PageRevision content field In Wagtail 3.0+, the PageRevision content_json TextField has been changed to a content JSONField. This commit updates the places in our code where we referenced that field. * Avoid unsafe chaining of Cypress functions https://docs.cypress.io/api/commands/scrollintoview Co-authored-by: Ans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: this PR is going into
upgrade/wagtail, notmain.)This PR updates the version of Wagtail used from 2.16.3 to 3.0.3.
With this PR it's possible to run a local server and load basic pages on the site. Note that some of our Python tests and some of our acceptance tests fail against this PR; see below for details.
This PR is primarily the code changes necessary to get
toxto even run completely and report test failures:This PR also includes a temporary pin of the wagtail-treemodeladmin package to the branch being worked on in cfpb/wagtail-treemodeladmin#34, as it adds 3.x support.
Notes and todos
The Python tests that fail here all relate to our custom code for StreamField migrations, which we document here. These fail because of this documented change to the way PageRevision data is stored. I would prefer to address those failures in another PR; see internal Design-and-Content-Team#117 for some context.
Besides the additional few functional test failures, there are definitely additional minor changes we'll want to make related to the Wagtail 3.0 upgrade; for example updating documentation that refers to the old Wagtail module paths, or deprecating our custom page description functionality, which we backported from 3.0 in #7134. I'd like to get this PR merged into
upgrade/wagtailto do the heavy lifting and then address those things in subsequent smaller PRs.Checklist