Support Wagtail 3.x and switch to pyproject.toml #34
Conversation
With [PEP 621 support added to setuptools](pypa/setuptools#2970) last year, and with pip supporting editable installs as of 21.3, we can move to `pyproject.toml` and deprecate `setup.py`. The file remains for legacy pip support. Because [flake8 does not want to support pyproject.tml yet](PyCQA/flake8#234), unlike all the other tools we use, I’m removing it in favor of [ruff](https://github.com/charliermarsh/ruff). This change also enables support for Wagtail 3.x by removing the `<3` version pin. This will result in the last release of TreeModelAdmin to support Wagtail < 4. Wagtail 4.x is not yet supported. The version is bumped to 1.5.0 for anticipated release to permit installing with Wagtail 3.x. I’ve also brought in some quality-of-life improvements for coverage checking from the Django-Flags tox/GHA setup.
willbarton
force-pushed
the
wag3-support
branch
from
4e6c2ea to
65891a5
Compare
There was a problem hiding this comment.
Functionally this seems to work the same against 3.0 as it does against 2.16.
There is a UI issue that gets introduced with the 3.0 upgrade, though: on the author page, the Edit button is strangely blank until you hover over it, and the Add text is misaligned.
| 2.16 | 3.0 |
|---|---|
 |
 |
This change drops the `button-secondary` class on the parent edit button to avoid creating custom CSS that works in both Wagtail 2 and Wagtail 3.
There was a problem hiding this comment.
UI consistency looks good! At least, close enough for government work (the misaligned plus is bothersome, but that doesn't seem to be anything you've customized here):
The version is bumped to 1.5.0 for anticipated release to permit installing with Wagtail 3.x.
Isn't the current version already 1.5.0? Maybe we leave the version alone for this PR, get #36 in after this one gets merged, and then bump separately?
I noticed one other issue with the coverage tests; besides that, this looks good to go.
Indeed! I must have misremembered to do the version bump after converting setup.py to pyproject.toml. That sounds like a good plan to me. |
This change fixes the version of Python the coverage Action uses. With the version of Python that tox is looking for not available, tox doesn't return non-zero, so the check passes even though it reports `coverage: skipped because could not find python interpreter with spec(s): python3.8`. This fixes that issue. Co-authored-by: Andy Chosak <[email protected]>
Co-authored-by: Andy Chosak <[email protected]>
willbarton
force-pushed
the
wag3-support
branch
from
dae89b3 to
7d7a308
Compare
With PEP 621 support added to setuptools last year, and with pip supporting editable installs as of 21.3, we can move to
pyproject.tomland deprecatesetup.py. The file remains for legacy pip support.Because flake8 does not want to support pyproject.tml yet, unlike all the other tools we use, I’m removing it in favor of ruff.
This change also enables support for Wagtail 3.x by removing the
<3version pin. This will result in the last release of TreeModelAdmin to support Wagtail < 4.Wagtail 4.x is not yet supported.
I’ve also brought in some quality-of-life improvements for coverage checking from the Django-Flags tox/GHA setup.
Checklist