feat: bolt-relay changes #10
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @thedevbirb and the rest of your teammates on |
mev-boost-relay/README.md
Outdated
| @@ -153,7 +153,6 @@ redis-cli DEL boost-relay/sepolia:validators-registration boost-relay/sepolia:va | |||
| * `FORCE_GET_HEADER_204` - force 204 as getHeader response | |||
| * `ENABLE_IGNORABLE_VALIDATION_ERRORS` - enable ignorable validation errors | |||
| * `USE_V1_PUBLISH_BLOCK_ENDPOINT` - uses the v1 publish block endpoint on the beacon node | |||
| * `USE_SSZ_ENCODING_PUBLISH_BLOCK` - uses the SSZ encoding for the publish block endpoint | |||
There was a problem hiding this comment.
Why did we get rid of SSZ encoding?
There was a problem hiding this comment.
I think it is a mistake. The new endpoint /relay/v1/builder/blocks_with_preconfs to submit block bids with proofs doesn't support SSZ yet (need to document it!) to move faster with the PoC; however I don't remember a reason to avoid ssz encoding while publishing... @merklefruit wdyt?
There was a problem hiding this comment.
yeah if the published type didn't change, no reason to have this removed. Probably a typo left in from an old attempt?
There was a problem hiding this comment.
I agree. We should restore it and test if something breaks with our other changes to the relay
thedevbirb
force-pushed
the
feat/bolt-relay-gt
branch
from
c5389e2 to
ce5dd22
Compare
refactor to comply to specs + SSZ enc/dec of spec types
No description provided.