Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Bolt-CLI: Use library for confirmation logic #674

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Chore: Bolt-CLI: Use library for confirmation logic #674

merged 2 commits into from
Jan 13, 2025

Conversation

0ex-d
Copy link
Contributor

@0ex-d 0ex-d commented Jan 13, 2025

Bolt-cli now uses inquire crate.

Improvements:

Impl request_confirmation() to Cmd struct.
For more information, please refer to this issue.
Closes #406

merklefruit
merklefruit reviewed Jan 13, 2025
View reviewed changes
bolt-cli/src/cli.rs Outdated Show resolved Hide resolved
@0ex-d 0ex-d requested a review from merklefruit January 13, 2025 17:42
merklefruit
merklefruit approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merklefruit merklefruit merged commit 1c10a21 into chainbound:unstable Jan 13, 2025
3 checks passed
thedevbirb
thedevbirb requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! A minor request

bolt-cli/src/common/mod.rs Show resolved Hide resolved
@0ex-d 0ex-d deleted the chore/use-crate-for-cli branch January 13, 2025 18:36
@0ex-d 0ex-d mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedevbirb thedevbirb thedevbirb requested changes

@merklefruit merklefruit merklefruit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use library for confirmation logic
3 participants
@0ex-d @merklefruit @thedevbirb