Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Bolt-CLI: exhaustive err match on inquire Error #675

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Chore: Bolt-CLI: exhaustive err match on inquire Error #675

merged 3 commits into from
Jan 14, 2025

Conversation

0ex-d
Copy link
Contributor

@0ex-d 0ex-d commented Jan 13, 2025

Tiny change on this review

@thedevbirb thedevbirb self-requested a review January 13, 2025 22:46
thedevbirb
thedevbirb requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@thedevbirb thedevbirb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a suggestion to make it a bit more explicit

bolt-cli/src/common/mod.rs Outdated Show resolved Hide resolved
@0ex-d 0ex-d requested a review from thedevbirb January 14, 2025 10:37
merklefruit
merklefruit approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

thedevbirb
thedevbirb approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@thedevbirb thedevbirb merged commit 03c427f into chainbound:unstable Jan 14, 2025
3 checks passed
@0ex-d 0ex-d deleted the fix/bolt-cli-inquire-err branch January 15, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedevbirb thedevbirb thedevbirb approved these changes

@merklefruit merklefruit merklefruit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0ex-d @merklefruit @thedevbirb