Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fruit fly RR genes #1252

Merged
merged 2 commits into from
Feb 7, 2025
Merged

fix: fruit fly RR genes #1252

merged 2 commits into from
Feb 7, 2025

Conversation

joyceyan
Copy link
Contributor

@joyceyan joyceyan commented Feb 7, 2025

Reason for Change

  • we received feedback from lattice here that some fruit fly genes start with RR

Changes

  • updated the gencode mapper to account for this

Testing

  • added fruit fly genes to valid_genes in test_gencode

Notes for Reviewer

@joyceyan joyceyan requested a review from Bento007 February 7, 2025 18:09
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.64%. Comparing base (241cefd) to head (d6196b5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1252   +/-   ##
=======================================
  Coverage   89.64%   89.64%           
=======================================
  Files          19       19           
  Lines        2222     2222           
=======================================
  Hits         1992     1992           
  Misses        230      230           
Components Coverage Δ
cellxgene_schema_cli 90.48% <100.00%> (ø)
migration_assistant 91.26% <ø> (ø)
schema_bump_dry_run_genes 79.74% <ø> (ø)
schema_bump_dry_run_ontologies 99.53% <ø> (ø)

@joyceyan joyceyan merged commit 3107d81 into main Feb 7, 2025
14 checks passed
@joyceyan joyceyan deleted the joyce/fix-rr-fly branch February 7, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants