Remove GitHub paginator and retrieve_dict_from_endpoint references #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating version
Signed-off-by: Andrew Brain <[email protected]>
Address release bugs
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Raise exceptions on graphql errors
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Augur 0.76.1 Release
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
augur/tasks/github/facade_github/contributor_interfaceable/contributor_interface.py
Outdated
Show resolved
Hide resolved
| import logging | ||
|
|
||
|
|
||
| from typing import List, Optional, Union, Generator, Tuple | ||
| from typing import Optional | ||
| from urllib.parse import urlencode, urlparse, parse_qs, urlunparse |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused urlencode imported from urllib.parse (unused-import)
| import logging | ||
|
|
||
|
|
||
| from typing import List, Optional, Union, Generator, Tuple | ||
| from typing import Optional | ||
| from urllib.parse import urlencode, urlparse, parse_qs, urlunparse |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused urlparse imported from urllib.parse (unused-import)
| import logging | ||
|
|
||
|
|
||
| from typing import List, Optional, Union, Generator, Tuple | ||
| from typing import Optional | ||
| from urllib.parse import urlencode, urlparse, parse_qs, urlunparse |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused parse_qs imported from urllib.parse (unused-import)
| import logging | ||
|
|
||
|
|
||
| from typing import List, Optional, Union, Generator, Tuple | ||
| from typing import Optional | ||
| from urllib.parse import urlencode, urlparse, parse_qs, urlunparse |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused urlunparse imported from urllib.parse (unused-import)
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
| @@ -3,7 +3,8 @@ | |||
| import time | |||
| import sqlalchemy as s | |||
| from augur.application.db.models import * | |||
| from augur.tasks.github.util.github_paginator import hit_api, process_dict_response, retrieve_dict_from_endpoint | |||
| from augur.tasks.github.util.github_paginator import hit_api, process_dict_response | |||
| from augur.tasks.github.util.github_data_access import GithubDataAccess, UrlNotFoundException | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused UrlNotFoundException imported from augur.tasks.github.util.github_data_access (unused-import)
| @@ -3,7 +3,8 @@ | |||
| import time | |||
| import sqlalchemy as s | |||
| from augur.application.db.models import * | |||
| from augur.tasks.github.util.github_paginator import hit_api, process_dict_response, retrieve_dict_from_endpoint | |||
| from augur.tasks.github.util.github_paginator import hit_api, process_dict_response | |||
| from augur.tasks.github.util.github_data_access import GithubDataAccess, UrlNotFoundException | |||
| # Debugger | |||
| import traceback | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused import traceback (unused-import)
Signed-off-by: Andrew Brain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Signed commits