Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augur 0.76.1 Release #2869

Merged
merged 47 commits into from
Jul 23, 2024
Merged

Augur 0.76.1 Release #2869

merged 47 commits into from
Jul 23, 2024

Conversation

sgoggins
Copy link
Member

Description

  • Release 0.76.1 - Collection logging and error checking

This PR fixes issues in the Augur TSC task dashboard

Ulincsys and others added 30 commits July 1, 2024 08:30
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Make Pylint Messages Exclusive Not Inclusive
Change log statements in contributor resolution to match new policy
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
ABrain7710 and others added 4 commits July 15, 2024 18:39
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
logger.info('Gunicorn webserver started...')
logger.info(f'Augur is running at: {"http" if development else "https"}://{host}:{port}')
logger.info(f"The API is available at '{api_response.json()['route']}'")

processes = start_celery_worker_processes(float(worker_vmem_cap), disable_collection)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0621: Redefining name 'processes' from outer scope (line 386) (redefined-outer-name)

@@ -7,6 +7,7 @@
from augur.tasks.util.worker_util import parse_json_from_subprocess_call
from augur.tasks.git.util.facade_worker.facade_worker.utilitymethods import get_absolute_repo_path
from augur.tasks.github.util.github_random_key_auth import GithubRandomKeyAuth

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused GithubRandomKeyAuth imported from augur.tasks.github.util.github_random_key_auth (unused-import)

@@ -293,9 +281,9 @@ def fetch_username_from_email(logger, auth, commit):

# Check if the email result got anything, if it failed try a name search.
if login_json is None or 'total_count' not in login_json or login_json['total_count'] == 0:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)

@@ -50,18 +49,18 @@ def collect_pull_requests(repo_git: str, full_collection: bool) -> int:
all_data.append(pr)

if len(all_data) >= 1000:
process_pull_requests(all_data, f"{owner}/{repo}: Pr task", repo_id, logger, augur_db)
process_pull_requests(all_data, f"{owner}/{repo}: Github Pr task", repo_id, logger, augur_db)
total_count += len(all_data)
all_data.clear()

if len(all_data):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C1802: Do not use len(SEQUENCE) without comparison to determine if a sequence is empty (use-implicit-booleaness-not-len)

total_count += len(all_data)
all_data.clear()

if len(all_data):
process_pull_requests(all_data, f"{owner}/{repo}: Pr task", repo_id, logger, augur_db)
process_pull_requests(all_data, f"{owner}/{repo}: Github Pr task", repo_id, logger, augur_db)
total_count += len(all_data)

if total_count > 0:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)

sgoggins and others added 7 commits July 17, 2024 16:18
Signed-off-by: Sean P. Goggins <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Raise exceptions on graphql errors
except ValueError as exc:
raise Exception(f"Error: totalCount is not an integer. Data: {data}") from exc

def __find_first_error_of_type(errors, type):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E0213: Method '__find_first_error_of_type' should have "self" as first argument (no-self-argument)


def __find_first_error_of_type(errors, type):

return next((error for error in errors if error.get("type").lower() == type.lower()), None)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E1133: Non-iterable value errors is used in an iterating context (not-an-iterable)

Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
@sgoggins sgoggins merged commit 5483169 into main Jul 23, 2024
9 of 10 checks passed
@ABrain7710 ABrain7710 deleted the augur_0.76.1 branch August 7, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants