Add a test for issue 4159 #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
approved these changes
Jun 11, 2024
| verilog should include("assign out1 = 8'h3;") | ||
| verilog should include("assign out2 = 8'h3;") | ||
| verilog should include("assign out3 = 8'h81;") | ||
| } |
There was a problem hiding this comment.
Scalatest doesn't have XFAIL, right? This would be better as that if it's supported. Alternatively, this could be a should not include which is the correct thing.
There was a problem hiding this comment.
I don't think ScalaTest has an XFAIL per se, more of should not include yeah. Are you suggesting I also add should not for the "correct" output when we fix this (ie. verilog should not include("assign out1 = 8'h81;") and verilog should not include("assign out2 = 8'h81;"))? Or are you suggesting something else?
Co-authored-by: Schuyler Eldridge <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Co-authored-by: Schuyler Eldridge <[email protected]> (cherry picked from commit 15115ea)
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Co-authored-by: Schuyler Eldridge <[email protected]> (cherry picked from commit 15115ea)
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Co-authored-by: Schuyler Eldridge <[email protected]> (cherry picked from commit 15115ea)
14 tasks
chiselbot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Co-authored-by: Schuyler Eldridge <[email protected]> (cherry picked from commit 15115ea) Co-authored-by: Jack Koenig <[email protected]>
chiselbot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Co-authored-by: Schuyler Eldridge <[email protected]> (cherry picked from commit 15115ea) Co-authored-by: Jack Koenig <[email protected]>
chiselbot
pushed a commit
that referenced
this pull request
Jun 12, 2024
Co-authored-by: Schuyler Eldridge <[email protected]> (cherry picked from commit 15115ea) Co-authored-by: Jack Koenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enshrine the behavior of #4159 - this test will be useful for backporting and then showing the change when we fix it.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.