Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Fix bug in zero-width memory removal (bp #2153) #2155

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 26, 2021

This is an automatic backport of pull request #2153 done by Mergify.

Cherry-pick of 67ce97a has failed:

On branch mergify/bp/1.3.x/pr-2153
Your branch is up to date with 'origin/1.3.x'.

You are currently cherry-picking commit 67ce97a1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/test/scala/firrtlTests/ZeroWidthTests.scala

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/main/scala/firrtl/passes/ZeroWidth.scala

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* Fix bug in zero-width memory removal

Correctly remove all extraneous connections to all types of memory
ports (read, write, readwrite) for zero-width memories.  Previously,
only read ports were correctly handled.

Signed-off-by: Schuyler Eldridge <[email protected]>

* fixup! Fix bug in zero-width memory removal

(cherry picked from commit 67ce97a)

# Conflicts:
#	src/main/scala/firrtl/passes/ZeroWidth.scala
@mergify mergify bot added bp-conflict Backport Automated backport, please consider for minor release labels Mar 26, 2021
@mergify mergify bot merged commit 0861510 into 1.3.x Mar 26, 2021
@mergify mergify bot deleted the mergify/bp/1.3.x/pr-2153 branch March 26, 2021 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backport Automated backport, please consider for minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant