This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Relax spec on 0-bit mux select, use SFC behavior #2285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the FIRRTL specification document to allow for 0-bit mux selects.
The existing ZeroWidths pass will promote these to a 1-bit, 0-valued
select signal (which effectively means that the mux can be optimized
away to just the false path).
Signed-off-by: Schuyler Eldridge [email protected]
Contributor Checklist
Type of Improvement
API Impact
None.
Backend Code Generation Impact
Non.e
Desired Merge Strategy
Release Notes
None.
Reviewer Checklist (only modified by reviewer)
Please Merge
?