Fix bugs from the switch to the publicsuffixlist package
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed when these functions were reworked. These functions no longer return a tuple so these error returns should not return a tuple.
Before we can write to the cache directory in the `load_suffix_list()` functions we need to ensure that the cache directory exists.
jsf9k
approved these changes
Feb 5, 2023
dav3r
approved these changes
Feb 6, 2023
9 tasks
jsf9k
added a commit
to cisagov/orchestrator
that referenced
this pull request
Feb 6, 2023
See cisagov/gatherer#97, cisagov/scanner#75, and cisagov/domain-scan#4 for more details.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Thie pull request fixes two issues with using the new Public Suffix List package we switched to in #2.
💭 Motivation and context
These two bugs (wrong return value and missing cache directory) cause breaking behavior.
🧪 Testing
I tested this change locally and in an updated cisagov/scanner Docker image.
✅ Pre-approval checklist