Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to pull in domain-scan fixes #75

Merged
merged 5 commits into from
Feb 8, 2023
Merged

Bump version to pull in domain-scan fixes #75

merged 5 commits into from
Feb 8, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Feb 6, 2023 •
edited
Loading

🗣 Description

This pull request bumps the version to pull in recent changes from cisagov/domain-scan#4.

💭 Motivation and context

BOD 18-01 scanning failed this weekend because of a few bugs in cisagov/domain-scan. @mcdonnnj fixed those bugs in cisagov/domain-scan#4.

🧪 Testing

BOD 18-01 scanning was successfully re-run with these changes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added bug This issue or pull request addresses broken functionality upstream update This issue or pull request pulls in upstream updates version bump This issue or pull request increments the version number labels Feb 6, 2023
@jsf9k jsf9k self-assigned this Feb 6, 2023
@jsf9k jsf9k marked this pull request as ready for review February 6, 2023 15:37
@jsf9k jsf9k requested review from dav3r and mcdonnnj as code owners February 6, 2023 15:37
@jsf9k jsf9k requested a review from a team February 6, 2023 15:40
jsf9k added a commit to cisagov/orchestrator that referenced this pull request Feb 6, 2023
@jsf9k
Use the latest gatherer and scanner Docker images
cc3bf24 
See cisagov/gatherer#97, cisagov/scanner#75, and cisagov/domain-scan#4
for more details.
jmorrowomni
jmorrowomni approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@jmorrowomni jmorrowomni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I count as one of your two for non-Kraken stuff yet, but LGTM

mcdonnnj
mcdonnnj approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jsf9k jsf9k merged commit 6d36151 into develop Feb 8, 2023
@jsf9k jsf9k deleted the bugfix/update_for_domain-scan_fixes branch February 8, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@jmorrowomni jmorrowomni jmorrowomni approved these changes

@dav3r dav3r dav3r approved these changes

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
bug This issue or pull request addresses broken functionality upstream update This issue or pull request pulls in upstream updates version bump This issue or pull request increments the version number
Projects
BOD 18-01
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @jmorrowomni @mcdonnnj