Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where Kali does not run user data scripts #179

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 15, 2025

🗣 Description

This pull request:

  • Modifies the Ansible code to no longer manually enable all cloud-init services, but instead only enable cloud-init-main.service
  • Modifies the Ansible code to use a DEB822-style repo for Neo4j
  • Removes the installation of resyncgg/ripgen

💭 Motivation and context

🧪 Testing

All automated tests pass. I also built a staging AMI, applied it to our COOL staging environment, and verified that it functions as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.
  • Build and test a staging AMI with these changes.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added bug This issue or pull request addresses broken functionality ansible Pull requests that update Ansible code labels Jan 15, 2025
@jsf9k jsf9k self-assigned this Jan 15, 2025
jsf9k added 5 commits January 16, 2025 08:55
This tool fails to build on the latest version of Kali Linux, and upon
checking we learned that it is not being used by assessors.
Kali Linux no longer supports the older style of repo.
jsf9k added 2 commits January 16, 2025 14:47
cloud-init-main.service is not currently enabled on Kali, although it
should be.  See canonical/cloud-init#5928 for more details.
@jsf9k jsf9k marked this pull request as ready for review January 17, 2025 02:57
@jsf9k jsf9k requested review from dav3r and mcdonnnj as code owners January 17, 2025 02:57
@jsf9k jsf9k requested a review from a team January 17, 2025 02:57
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@jsf9k jsf9k enabled auto-merge January 17, 2025 18:37
@jsf9k jsf9k merged commit 71d7c62 into develop Jan 17, 2025
8 checks passed
@jsf9k jsf9k deleted the bugfix/cloud-init branch January 17, 2025 19:54
@jsf9k jsf9k changed the title Stop manually enabling cloud-init services Fix bug where Kali does not run user data scripts Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Pull requests that update Ansible code bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kali AMI does not run user data scripts
3 participants