Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email sending to the portfolio domain assignment review page #3295

Closed
3 tasks done
Tracked by #3296
abroddrick opened this issue Jan 3, 2025 · 0 comments · Fixed by #3321
Closed
3 tasks done
Tracked by #3296

Add email sending to the portfolio domain assignment review page #3295

abroddrick opened this issue Jan 3, 2025 · 0 comments · Fixed by #3321
Assignees
Labels
bundled Parent ticket will be sprinted and this ticket is included in the parent dev issue is for the dev team

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Jan 3, 2025

Issue description

As a portfolio member with permissions to edit member info
I want a domain invitation email to send to an invited member or existing member when I assign domains to that user
so that they get a single email notification of which domains they have been invited to manage.

Acceptance criteria

  • On the Members- Domain Assignment review page(for portfolios) send domain invitation emails when an invited user or existing is invited to a manage a domain
    • only send emails on members page if at least one new domain invitation is created, or one that was "canceled" is now switched to "invited", or at least one new user domain role was created
      • this is to avoid sending duplicate emails to a user
      • you do not need to send an email if the only change is that a domain invitation was canceled
  • the email sent should match all the ACs in Dev: Make updates to domain invitation emails #2960 using the same dynamic email that will change language based on if a user is invited to one domain vs multiple domains

Additional context

Reminder: this should send if domain invitations are created or user domain roles are created. Don't forget the user domain roles too.

#2960 and #3019 send a portfolio email if the user is not invited to a portfolio, this should not happen with this page, however, I suggest adding in the same logic but also log this as an error that the portfolio invitation didn't exist

This was pulled out of #2960 as that ticket had a lot in it affecting multiple areas. Both tickets can be done together (in the same or separate PRs) up to the developer's discretion.

Links to other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bundled Parent ticket will be sprinted and this ticket is included in the parent dev issue is for the dev team
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants