Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Make updates to domain invitation emails #2960

Closed
11 of 12 tasks
Tracked by #3296
Katherine-Osos opened this issue Oct 18, 2024 · 2 comments · Fixed by #3321
Closed
11 of 12 tasks
Tracked by #3296

Dev: Make updates to domain invitation emails #2960

Katherine-Osos opened this issue Oct 18, 2024 · 2 comments · Fixed by #3321
Assignees
Labels
🔔 Notifications related to notification (email) sent to users blocked Is dependent on another issue and cannot be worked bundled Parent ticket will be sprinted and this ticket is included in the parent dev issue is for the dev team Feature: 🏢 Org Model refinement

Comments

@Katherine-Osos
Copy link
Contributor

Katherine-Osos commented Oct 18, 2024

Story

As a recipient of a domain invitation
I want the system to recognize whether I'm invited to multiple domains and if I'm already a user of the registrar
so that I'm only sent relevant information.

Acceptance Criteria

Make the following updates to the domain invitation email (applies to org model AND non-org model):

  • Display dynamic text based on whether someone was invited to a single domain or multiple domains.
  • In the greeting, display the user's name if they're already a "user" in our system.
    • Simply display "Hi." if not a user in the system.
  • Display the section about needing a Login.gov account only if the invitee is not a “user” in our system yet.
  • Ensure the email reflects this updated content

When invitations are sent for domains that are part of Org Model, double check that this AC from previous ticket #3019 is still intact

  • If the invitee is not part of the portfolio yet, send the portfolio invitation email AND the domain invitation email.

  • The above ACs apply to domain invitations send from the following:

    • Django admin
    • Domain Managers page (on a domain page)
  • On django admin, if a new domain invitation is created then send the same emails mentioned above (domain invitation and portfolio invitation if applicable) (the alert warning will be added to this table in Dev: Send emails when someone is added as a domain manager #2370 )

Error handling for non-unique user email:

  • When making a domain invitation for an existing user, check for non-unique user email and trigger error msg/log on DJA and on the form View. Send email, do not proceed with creating the user domain role. @dave-kennedy-ecs @abroddrick @rachidatecs discussed handling this edge case on the oidc side

Portfolio invites on existing user:

  • If someone is invited to a portfolio and they are already a registrar user, we should automatically create their user portfolio permission record (auto-retrieve the portfolio invite). This applies to straight portfolio invites, also applies to the 'side-effect' portfolio invites that get triggered on domain invites.

Additional Context

this will be added to the members page in #3295 , you can do these two in the same PR if desirable, it was just seperated in case someone wants to do them in separate PRs (and since it is a different area in the code/unit tests)

Issue Links

@Katherine-Osos
Copy link
Contributor Author

Katherine-Osos commented Oct 18, 2024

@abroddrick I'm wondering if we can consolidate the use cases into one email that dynamically displays slightly different language if a user is invited to a single domain vs multiple domains OR if user is invited via Member page vs directly from a Domain page. Let's discuss in refinement.

@katypies katypies added the 🔔 Notifications related to notification (email) sent to users label Oct 21, 2024
@katypies katypies moved this from 👶 New to 🍦 Backlog in .gov Product Board Oct 21, 2024
@Katherine-Osos Katherine-Osos changed the title Dev: User is notified when invited to multiple domains via Member page Dev: Make updates to domain invitation emails Nov 1, 2024
@lizpearl lizpearl added the blocked Is dependent on another issue and cannot be worked label Nov 25, 2024
@abroddrick
Copy link
Contributor

Refinement as we will need to discuss in the org model meeting about the impacts with us adding requests to production orgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔔 Notifications related to notification (email) sent to users blocked Is dependent on another issue and cannot be worked bundled Parent ticket will be sprinted and this ticket is included in the parent dev issue is for the dev team Feature: 🏢 Org Model refinement
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

6 participants