Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysts/superusers adding domain managers via "Manage Domain" button sends emails #3332

Open
2 tasks
abroddrick opened this issue Jan 13, 2025 · 0 comments
Open
2 tasks
Assignees
Labels
dev issue is for the dev team Feature: 🏢 Org Model

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Jan 13, 2025

Issue description

We added email sending on the registrar and django admin when someone is invited/added as a domain manager to a domain. However, one hole in the current logic is that analysts who login to django admin, and click the "Manage Domain" button for a portfolio's domain, then add/invite someone as a domain manager will not have "portfolio invitation" created or the email sent inviting the person to the domain. There is also no language telling the analyst the invitation will not be sent. We want instead to make sure that portfolio invitations are sent if the domain is part of a portfolio.

Acceptance criteria

  • Analyst/full access user can clickthe Manage Domain button on a portfolio's domain and adding someone to a domain (invitation or user domain role) via the Domain Managers tab in the registrar should send a portfolio invitation to the user if the domain has a portfolio attached.
  • follow the normal logic for portfolio invitations, such as only send an email if the portfolio invitation doesn't exist, and don't create duplicate/ multiple portfolio invitations.

Additional context

No response

Links to other issues

@abroddrick abroddrick added the dev issue is for the dev team label Jan 13, 2025
@abroddrick abroddrick changed the title Analysts adding/removing domain managers via "Manage Domain" button sends email Analysts addingdomain managers via "Manage Domain" button sends email Jan 13, 2025
@abroddrick abroddrick changed the title Analysts addingdomain managers via "Manage Domain" button sends email Analysts addingdomain managers via "Manage Domain" button sends emails Jan 13, 2025
@abroddrick abroddrick changed the title Analysts addingdomain managers via "Manage Domain" button sends emails Analysts adding domain managers via "Manage Domain" button sends emails Jan 14, 2025
@abroddrick abroddrick moved this from 👶 New to 🎯 Ready in .gov Product Board Jan 14, 2025
@abroddrick abroddrick changed the title Analysts adding domain managers via "Manage Domain" button sends emails Analysts/superusers adding domain managers via "Manage Domain" button sends emails Jan 14, 2025
@dave-kennedy-ecs dave-kennedy-ecs self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev issue is for the dev team Feature: 🏢 Org Model
Projects
Status: 🎯 Ready
Development

No branches or pull requests

2 participants