Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ansible versions greater than 6 #173

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Mar 1, 2024

🗣 Description

This pull request removed the upper bound on the version of Ansible installed.

💭 Motivation and context

Ansible 9 appears to function without issue.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added the dependencies Pull requests that update a dependency file label Mar 1, 2024
@jsf9k jsf9k self-assigned this Mar 1, 2024
@jsf9k jsf9k added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Mar 1, 2024
@jsf9k jsf9k marked this pull request as ready for review March 1, 2024 18:55
@jsf9k jsf9k requested a review from a team March 1, 2024 18:55
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me but I have a suggestion for your consideration.

requirements-test.txt Outdated Show resolved Hide resolved
Ansible 9 appears to function without issue.

Co-authored-by: Nick <[email protected]>
@jsf9k jsf9k force-pushed the improvement/use-recent-version-of-ansible branch from e9fd8f6 to d8b06f3 Compare March 1, 2024 20:50
@jsf9k jsf9k requested a review from mcdonnnj March 1, 2024 20:51
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@mcdonnnj mcdonnnj added this pull request to the merge queue Mar 27, 2024
@mcdonnnj mcdonnnj removed this pull request from the merge queue due to the queue being cleared Mar 27, 2024
@mcdonnnj mcdonnnj added this pull request to the merge queue Mar 27, 2024
@mcdonnnj mcdonnnj removed this pull request from the merge queue due to the queue being cleared Mar 27, 2024
@mcdonnnj mcdonnnj added this pull request to the merge queue Mar 27, 2024
Merged via the queue into develop with commit 680a61f Mar 27, 2024
12 checks passed
@mcdonnnj mcdonnnj deleted the improvement/use-recent-version-of-ansible branch March 27, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants