Pin the version of the ansible package
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
bug
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
jsf9k
approved these changes
Mar 6, 2024
|
I suggest that the bug tag is a bit strong for this PR. Improvement would be a better fit IMHO. |
I'm calling it a bug because the dependency should have been pinned alongside cisagov/skeleton-ansible-role@839fe4b almost four years ago. We're just lucky the build process hasn't allowed a stale version of Ansible to be used or we would have noticed things breaking unexpectedly for some image configurations. |
mcdonnnj
added
the
kraken 🐙
michaelsaki
approved these changes
Mar 6, 2024
We should be pinning the version of Ansible we use in our Packer projects to mirror the version used in our Ansible role projects. Co-authored-by: Shane Frasier <[email protected]>
mcdonnnj
force-pushed
the
bug/pin_ansible_version
branch
from
f2303b9 to
dd67feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds a version pin constraint for the ansible package in the requirements. This pin constraint matches the one in cisagov/skeleton-ansible-role#173.
💭 Motivation and context
We should be mirroring the version of ansible used by cisagov/skeleton-ansible-role and its descendants to ensure consistency.
🧪 Testing
This pull request needs #295 to pass tests. You can see everything working as expected in this run on a branch that combines both branches.
✅ Pre-approval checklist