Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code to use the "docker compose" syntax vice "docker-compose" #105

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Update code to use the "docker compose" syntax vice "docker-compose" #105

merged 3 commits into from
Jun 13, 2022

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jun 7, 2022

🗣 Description

This pull request updates the code to use the docker compose syntax instead of the docker-compose syntax.

💭 Motivation and context

The docker compose syntax is the preferred (and only correct) syntax after the changes in cisagov/ansible-role-docker#60.

🧪 Testing

Automated testing passes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

@jsf9k
Update code to use the "docker compose" syntax vice "docker-compose"
499d1d5 
The "docker compose" syntax is the preferred (and only correct) syntax
after the changes in cisagov/ansible-role-docker#60.
@jsf9k jsf9k self-assigned this Jun 7, 2022
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality blocked This issue or pull request is awaiting the outcome of another issue or pull request breaking change This issue or pull request involves changes to existing functionality labels Jun 7, 2022
@jsf9k
Copy link
Member Author

jsf9k commented Jun 7, 2022

Note that the GitHub Actions should pass once #79 is merged.

@jsf9k jsf9k marked this pull request as ready for review June 8, 2022 18:03
@jsf9k jsf9k requested review from dav3r, felddy and mcdonnnj as code owners June 8, 2022 18:03
dav3r
dav3r approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mcdonnnj added a commit that referenced this pull request Jun 13, 2022
@mcdonnnj
Merge pull request #105 from cisagov/maintenance/update_pre-commit_hooks
da532a5 
Update `pre-commit` hooks
mcdonnnj
mcdonnnj approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggestion. Thanks for getting us updated!

docker-compose.yml Outdated Show resolved Hide resolved
@mcdonnnj mcdonnnj merged commit 9cea64d into develop Jun 13, 2022
@mcdonnnj mcdonnnj deleted the bugfix/update-docker-compose-syntax branch June 13, 2022 15:25
@mcdonnnj mcdonnnj linked an issue Dec 6, 2024 that may be closed by this pull request
Switch "docker-compose" to "docker compose". #54
Closed
2 tasks
@mcdonnnj mcdonnnj mentioned this pull request Dec 6, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request breaking change This issue or pull request involves changes to existing functionality bug This issue or pull request addresses broken functionality
Projects
Next Kraken
Status: Done
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch "docker-compose" to "docker compose".
3 participants
@jsf9k @dav3r @mcdonnnj