Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage pull request for: skeleton #79

Merged
merged 31 commits into from
Jun 13, 2022
Merged

Lineage pull request for: skeleton #79

merged 31 commits into from
Jun 13, 2022

Conversation

cisagovbot
Copy link

Lineage Pull Request

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-generic.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.


Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

Update pre-commit hooks using `pre-commit autoupdate`.
This comment explains that the configuration may have commented out
ignore directives that should be uncommented in downstream projects.
yamllint does not like it when you comment out pieces of dictionaries
in lists. Upcoming additions to the Dependabot configuration will run
afoul of this so we are updating the yamllint configuration.
…_yamllint_configurations

Add boilerplate for upcoming Dependabot configuration changes
@cisagovbot cisagovbot added the upstream update This issue or pull request pulls in upstream updates label Feb 25, 2022
Given the inconsistent behavior of underscores used within words for
style we should prefer asterisks now that these rules are available.
…configuration

Use new `markdownlint` rules for emphasis- and strong-styles
dependabot bot and others added 7 commits February 28, 2022 18:02
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 3.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook
is intentionally held back due to issues with upgrading to v6.
This adds commented out ignore directives for the following GitHub
Actions:

- action/cache
- action/checkout
- action/setup-python

These should be uncommented downstream to ensure that updates to these
dependencies are pushed from pull requests made in the skeleton.
…s/setup-python-3

Bump actions/setup-python from 2 to 3
mcdonnnj and others added 12 commits April 1, 2022 12:16
…s/checkout-3

Bump actions/checkout from 2 to 3
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2...v3)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…es_for_github_actions

Add Dependabot ignore directives
…s/cache-3

Bump actions/cache from 2 to 3
Use Python 3.10 for the `lint` job in GitHub Actions
Add hooks to validate GitHub Actions and GitHub Action workflows. These
are validated using JSON Schemas.
…re-commit_hooks

Add `pre-commit` hooks to validate GitHub Actions content
@mcdonnnj mcdonnnj force-pushed the lineage/skeleton branch from c11e08d to 48d76c4 Compare May 29, 2022 21:43
mcdonnnj added 3 commits May 30, 2022 01:40
Uncomment the `github-actions` Dependabot ignore directives because
those dependencies are managed by cisagov/skeleton-generic upstream.
We must ensure that all `workflow_dispatch` input defaults are string
values. This ensures expected behavior instead of relying on automatic
type conversions.
@mcdonnnj mcdonnnj force-pushed the lineage/skeleton branch from 48d76c4 to 534fb66 Compare May 30, 2022 05:40
@mcdonnnj mcdonnnj requested review from jsf9k and dav3r May 30, 2022 05:50
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 🐳

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one minor question, but otherwise this all looks great.

.github/workflows/build.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream update This issue or pull request pulls in upstream updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants