Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use provider default_tags instead of manually passing tags to modules #74

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Use provider default_tags instead of manually passing tags to modules #74

merged 1 commit into from
Jun 11, 2021

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jun 11, 2021 •
edited
Loading

🗣 Description

This pull request:

  • Alphabetizes the keys inside provider blocks
  • Adds a default_tags key to each provider block
  • Modifies code to use the provider's default_tags instead of passing tags explicitly to modules

💭 Motivation and context

Once cisagov/ami-build-iam-user-tf-module#27 is merged, passing tags to the module will at best not function as intended and at worst will be an error.

🧪 Testing

All pre-commit hooks pass.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label Jun 11, 2021
@jsf9k jsf9k self-assigned this Jun 11, 2021
@jsf9k jsf9k marked this pull request as ready for review June 11, 2021 19:50
@jsf9k jsf9k requested review from dav3r, felddy and mcdonnnj as code owners June 11, 2021 19:50
dav3r
dav3r approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Riiight- we talked about this and I totally forgot about it. Nice catch! 👍

mcdonnnj
mcdonnnj approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for catching this. 👍

@jsf9k jsf9k merged commit 4243d84 into develop Jun 11, 2021
@jsf9k jsf9k deleted the bugfix/use-provider-default-tags branch June 11, 2021 20:51
@jsf9k jsf9k mentioned this pull request Jun 11, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
bug This issue or pull request addresses broken functionality
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj