Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repeated typo #75

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Fix repeated typo #75

merged 1 commit into from
Jun 11, 2021

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jun 11, 2021 •
edited
Loading

🗣 Description

This pull request fixes a typo that was copied and pasted many times in #74.

💭 Motivation and context

If we don't fix this typo then we get a syntax error.

🧪 Testing

All pre-commit hooks pass.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label Jun 11, 2021
@jsf9k jsf9k self-assigned this Jun 11, 2021
@jsf9k jsf9k marked this pull request as ready for review June 11, 2021 21:22
@jsf9k jsf9k requested review from dav3r, felddy and mcdonnnj as code owners June 11, 2021 21:22
mcdonnnj
mcdonnnj approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot believe I missed this on review -,-

@mcdonnnj
Copy link
Member

This highlights how we need to enable terraform validate checking as soon as we migrate to Terraform 0.13+.

@jsf9k
Copy link
Member Author

jsf9k commented Jun 11, 2021

I cannot believe I missed this on review -,-

In my defense, the shift key on my keyboard is acting up today. Still pretty bone-headed of me to make the mistake in the first place. I blame society, as always.

dav3r
dav3r approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@jsf9k jsf9k merged commit f97a650 into develop Jun 11, 2021
@jsf9k jsf9k deleted the bugfix/fix-repeated-typo branch June 11, 2021 21:31
jsf9k added a commit that referenced this pull request Jul 9, 2021
@jsf9k
fixup! Merge pull request #75 from cisagov/bugfix/fix-repeated-typo
0fdaaad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
bug This issue or pull request addresses broken functionality
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @mcdonnnj @dav3r