Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing build #120

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Fix failing build #120

merged 5 commits into from
Jun 26, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jun 23, 2024 •
edited
Loading

🗣 Description

This pull request:

💭 Motivation and context

  • The build needs to succeed, obviously.
  • The warning pointed out the use of Dockerfile syntax that may be removed in a future release, so it is best to get rid of it.

🧪 Testing

All automated tests succeed. I also re-ran all of this week's tmail reports with these changes and verified that everything succeeded.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

jsf9k added 4 commits June 23, 2024 13:31
@jsf9k
Pin numpy to <2
fb85737 
numpy>=2 lacks the numpy/noprefix.h header, which is required when
building the wheel for matplotlib~=2.2.3.
@jsf9k
Use the ENV <key>=<value> syntax vice the ENV <key> <value> syntax
3dfc3f0 
This gets rid of a warning from docker build.  Also, the Dockerfile
documentation states that the latter syntax is not preferred and may
be removed in the future:
https://docs.docker.com/reference/dockerfile/#env
@jsf9k
Bump version from 1.5.5 to 1.5.6
d94ac21
@jsf9k
Bump version from 1.5.6 to 1.5.6-rc.1
8f1746e
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number labels Jun 23, 2024
@jsf9k jsf9k self-assigned this Jun 23, 2024
@jsf9k jsf9k marked this pull request as ready for review June 25, 2024 15:53
@jsf9k jsf9k requested a review from a team June 25, 2024 15:53
mcdonnnj
mcdonnnj approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔

@jsf9k jsf9k enabled auto-merge June 25, 2024 20:08
@jsf9k jsf9k merged commit 561b24a into develop Jun 26, 2024
17 checks passed
@jsf9k jsf9k deleted the bugfix/fix-failing-build branch June 26, 2024 00:50
jsf9k added a commit to cisagov/orchestrator that referenced this pull request Jun 26, 2024
@jsf9k
Use the latest version of the cisagov/trustymail_reporter Docker cont…
688cd4f 
…ainer

The latest version is the same, except that some build errors were
fixed.  See cisagov/trustymail_reporter#120 for more details.
@jsf9k jsf9k mentioned this pull request Jun 26, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

Assignees

@jsf9k jsf9k

Labels
bug This issue or pull request addresses broken functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number
Projects
BOD 18-01
Status: Done
CyHy System
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj