Fix the URL used for the Docker Pull shield
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was pointing to a nonexistent Docker image that was not in line with the other URLs in the `Docker Image` section of the README.
|
N.B. The tests on this will fail because of the issue that is resolved in #18 . Since this is a simple URL change in the README I will just merge without passing all the tests since the lint job completes successfully. |
jsf9k
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR fixes the image URL for the
docker pullsimage shield.💭 Motivation and context
The URL incorrectly referenced
cisagov/vdp-scanner-dockerwhen the image is pushed to Docker Hub ascisagov/vdp-scanner.🧪 Testing
Automated tests pass. I confirm that the image shield works as expected in this branch.
✅ Checklist