Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile Versions #18

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This PR updates the base Docker image tags to specify which Debian version. It also updates the Debian package versions to install to correspond to the image tags used now.

💭 Motivation and context

With the release of Debian Bullseye the 3.9.6 and 3.9.6-slim tags for the python Docker image no longer used the underlying 3.9.6-buster and 3.9.6-slim-buster image tags. This results in an inability to build an image successfully. This was resolved by moving away from shared tags for the Docker images used and using the very specific 3.9.6-bullseye and 3.9.6-slim-bullseye image tags instead. The apt package versions had to be updated to correspond with this change in Debian versions.

🧪 Testing

Automated tests pass. After building a local testing image I was able to successfully use this Docker image.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

The `3.9.6` and `3.9.6-slim` tags are shared tags that changed references from
`3.9.6-buster` to `3.9.6-bullseye` upon the release of Debian Bullseye on
2021-08-14. This is undesirable behavior for repeatable builds so I have made
the tag we use as specific as possible.
With the switch to a Debian Bullseye based image we need to update the version
pins so that an image can successfully build.
@mcdonnnj mcdonnnj added bug This issue or pull request addresses broken functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Aug 18, 2021
@mcdonnnj mcdonnnj self-assigned this Aug 18, 2021
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@mcdonnnj mcdonnnj merged commit df66256 into develop Aug 18, 2021
@mcdonnnj mcdonnnj deleted the bug/update_docker_dependencies branch August 18, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants