-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Remove civicrm.files override for WordPress to fix issues with… #17868
[REF] Remove civicrm.files override for WordPress to fix issues with… #17868
Conversation
… users struggling to find extensions
(Standard links)
|
@seamuslee001 it's hard to find the issue and steps to reproduce from a Mattermost thread. I ran the initial PR through all my test sites (Single site, Multi-site, mapped domains, wp-content dir moved, wp in a sub directory) which is quite substantial. I'd like to understand the problem we are solving and how to recreate before I dive in there again. From what I read we are still trying to support a directory path we deprecated in version 4.6. It's far better to document moving to the proper paths or adding overrides for custom locations. And I consider |
Yeah, this patch is a bit rough - feels like we're just as likely to break something else. Whenever there's a bug in path/URL computation, I would suggest running this to help diagnose the problem: https://gist.github.com/totten/5997ff53088b159e7275f761e52f9516 The main thing is to get the report running in the problematic environment. (The suggestions in the first 5 or so lines for some specific environments - but that bit has to be adapted.) |
Thanks @seamuslee001 We have seen this problem with WordPress sites on CiviCRM 5.27 where: The Settings - Upload Directories were set correctly and in the most recent case, was using an absolute path for the directories. Removing the [civicrm.files] token use in the Resource URLs was the solution in all cases. |
For these WordPress sites, these are single site installs. Not multi-site, very vanilla WordPress set up and standard hosting - nothing special. We've seen the problem and there's been recent reports of the problem in Mattermost to boot. |
@agileware-justin Any chance you can run Tim's script on a site that had issues. This is output from a 5.27.2 local site of mine: https://gist.github.com/kcristiano/ff8098d3f3d0ea8f82c55fa362dc62d1 This is handbuilt master https://gist.github.com/kcristiano/b056b2394233ffb3adf1d0d378838b04 My concern about removing the code from |
@kcristiano yes we can clone the site and re-test. Will do that next week (or on the weekend), if that's OK. |
@seamuslee001 I would not recommend removing this block of code. It overrides the default method for discovering CiviCRM's Admittedly, the paths are only correct for CiviCRM installs which do not use the legacy locations for the Removing this code would mean that any installs which do use the |
@seamuslee001 I think it's fairly clear this is not going into the rc as is - move to gitlab? |
@agileware-justin can you make sure there is an adequate gitlab for this - this doesn't seem like 'the fix' but we definitely need to track fixing it - if we have a gitlab (with a regression label) we can close this without losing sight of it |
@christianwach sure appreciate that feeling, I was mostly looking at it from the approach of 'stuff started failing according to people i know in 5.27 what changed?' @eileenmcnaughton @agileware-justin @kcristiano @christianwach closing for now and have opened the gitlab here https://lab.civicrm.org/dev/wordpress/-/issues/66 |
Posted a comment with the results of testing here, https://lab.civicrm.org/dev/wordpress/-/issues/66#note_40826 |
reopening based on https://lab.civicrm.org/dev/wordpress/-/issues/66 |
jenkins re-test this please |
jenkins test this please |
Test failure is unrelated I take it this should be merged right @kcristiano ? |
@seamuslee001 I have done many |
thanks @kcristiano |
… users struggling to find extensions
Overview
This removes the
civicrm.files
token override which seems to have caused some issues for users on upgrade to 5.27 see this thread https://chat.civicrm.org/civicrm/pl/mmqxdjnap3b4ubbeqwnn7kdxgcBefore
civicrm.files gives off potentially the wrong file path
After
civicrm.files gives off the correct civicrm files file path
ping @jusfreeman @kcristiano @christianwach