Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8-compat] Fix some more examples of where required parameters are… #20515

Merged
merged 1 commit into from
Jun 6, 2021

Conversation

seamuslee001
Copy link
Contributor

… after optional parameters in fucntion declaration

Overview

This fixes a few more unit tests caused by issues where by in a function declaration required parameters are after optional ones and also fixes a e-notice in block.localize.php

Before

Tests fail

After

Tests pass

ping @eileenmcnaughton @demeritcowboy @totten

… after optional parameters in fucntion declaration
@civibot
Copy link

civibot bot commented Jun 5, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

image

I believe that statement should be qualified....

@seamuslee001 seamuslee001 merged commit 5921b4e into civicrm:master Jun 6, 2021
@seamuslee001 seamuslee001 deleted the php8_required_optional branch June 6, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants