Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8-compat] Fix some more examples of where required parameters are… #20515

Merged
merged 1 commit into from
Jun 6, 2021
Merged

[php8-compat] Fix some more examples of where required parameters are… #20515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CRM/Activity/Import/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ abstract class CRM_Activity_Import_Parser extends CRM_Import_Parser {
*/
public function run(
array $fileName,
$separator = ',',
$separator,
&$mapper,
$skipColumnHeader = FALSE,
$mode = self::MODE_PREVIEW,
Expand Down
2 changes: 1 addition & 1 deletion CRM/Campaign/Form/Campaign.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ public function postProcess() {
}
}

public static function submit($params = [], $form) {
public static function submit($params, $form) {
$groups = [];
if (!empty($params['includeGroups']) && is_array($params['includeGroups'])) {
foreach ($params['includeGroups'] as $key => $id) {
Expand Down
2 changes: 1 addition & 1 deletion CRM/Contribute/Import/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ abstract class CRM_Contribute_Import_Parser extends CRM_Import_Parser {
*/
public function run(
$fileName,
$separator = ',',
$separator,
&$mapper,
$skipColumnHeader = FALSE,
$mode = self::MODE_PREVIEW,
Expand Down
2 changes: 1 addition & 1 deletion CRM/Core/Smarty/plugins/block.localize.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function smarty_block_localize($params, $text, &$smarty) {
$lines = [];
foreach ($smarty->_tpl_vars['locales'] as $locale) {
$line = $text;
if ($params['field']) {
if (isset($params['field'])) {
$fields = explode(',', $params['field']);
foreach ($fields as $field) {
$field = trim($field);
Expand Down
4 changes: 2 additions & 2 deletions CRM/Event/Form/Registration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,7 +1100,7 @@ public function overrideExtraTemplateFileName() {
* @param array $optionFullIds
* @param CRM_Core_Form $form
*/
public static function resetElementValue($optionFullIds = [], &$form) {
public static function resetElementValue($optionFullIds, &$form) {
if (!is_array($optionFullIds) ||
empty($optionFullIds) ||
!$form->isSubmitted()
Expand Down Expand Up @@ -1173,7 +1173,7 @@ public static function resetElementValue($optionFullIds = [], &$form) {
* @param array $optionIds
* @param CRM_Core_Form $form
*/
public static function resetSubmittedValue($elementName, $optionIds = [], &$form) {
public static function resetSubmittedValue($elementName, $optionIds, &$form) {
if (empty($elementName) ||
!$form->elementExists($elementName) ||
!$form->getSubmitValue($elementName)
Expand Down
2 changes: 1 addition & 1 deletion CRM/Event/Import/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ abstract class CRM_Event_Import_Parser extends CRM_Import_Parser {
*/
public function run(
$fileName,
$separator = ',',
$separator,
&$mapper,
$skipColumnHeader = FALSE,
$mode = self::MODE_PREVIEW,
Expand Down
2 changes: 1 addition & 1 deletion CRM/Member/Import/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ abstract class CRM_Member_Import_Parser extends CRM_Import_Parser {
*/
public function run(
$fileName,
$separator = ',',
$separator,
&$mapper,
$skipColumnHeader = FALSE,
$mode = self::MODE_PREVIEW,
Expand Down