[create-cloudflare] next.js with ts fix (#7854)

* resolves #925 * fixes issue name * fix(create-cloudflare): update version from major to patch * Revert last 3 commits * fix(create-cloudflare): removed top-level await in next.config.ts * fix(create-cloudflare): typo fix * fix(create-cloudflare): changeset fix * fix(create-cloudflare): Update .changeset/famous-coats-admire.md Co-authored-by: Victor Berchet <[email protected]> * fix(create-cloudflare): Update .changeset/famous-coats-admire.md 2 * fix(create-cloudflare): Update .changeset/famous-coats-admire.md 3 Co-authored-by: Victor Berchet <[email protected]> * fix(create-cloudflare): pnpm fix on changeset --------- Co-authored-by: Berat BAYRAM <[email protected]> Co-authored-by: Victor Berchet <[email protected]> Co-authored-by: Carmen Popoviciu <[email protected]>
cloudflare · Feb 10, 2025 · eabd9b3 · eabd9b3
1 parent 35c1dc3
commit eabd9b3
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/.changeset/famous-coats-admire.md b/.changeset/famous-coats-admire.md
@@ -0,0 +1,8 @@
+---
+"create-cloudflare": patch
+---
+
+Update the Next.js template
+
+- Removed top-level `await` in `next.config.ts` as it is not allowed there and not required.
+- Improved `setupDevPlatform()` comment
diff --git a/packages/create-cloudflare/templates/next/c3.ts b/packages/create-cloudflare/templates/next/c3.ts
@@ -42,12 +42,12 @@ const updateNextConfig = (usesTs: boolean) => {
 	const updatedConfigFile =
 		`import { setupDevPlatform } from '@cloudflare/next-on-pages/next-dev';
 
-		// Here we use the @cloudflare/next-on-pages next-dev module to allow us to use bindings during local development
-		// (when running the application with \`next dev\`), for more information see:
+		// Here we use the @cloudflare/next-on-pages next-dev module to allow us to
+		// use bindings during local development (when running the application with
+		// \`next dev\`). This function is only necessary during development and
+		// has no impact outside of that. For more information see:
 		// https://github.com/cloudflare/next-on-pages/blob/main/internal-packages/next-dev/README.md
-		if (process.env.NODE_ENV === 'development') {
-		  await setupDevPlatform();
-		}
+		setupDevPlatform().catch(console.error);
 
 		`.replace(/\n\t*/g, "\n") + configContent;
 

diff --git a/packages/workers-shared/asset-worker/src/index.ts b/packages/workers-shared/asset-worker/src/index.ts
@@ -217,7 +217,7 @@ export default class extends WorkerEntrypoint<Env> {
 		const analytics = new ExperimentAnalytics(this.env.EXPERIMENT_ANALYTICS);
 		const performance = new PerformanceTimer(this.env.UNSAFE_PERFORMANCE);
 
-		const INTERPOLATION_EXPERIMENT_SAMPLE_RATE = 0;
+		const INTERPOLATION_EXPERIMENT_SAMPLE_RATE = 1 / 20_000; // 0.00005 = 0.005%
 		let searchMethod: "binary" | "interpolation" = "binary";
 		if (Math.random() < INTERPOLATION_EXPERIMENT_SAMPLE_RATE) {
 			searchMethod = "interpolation";