Version Packages #925
Merged
Version Packages #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
threepointone and
petebacondarwin
as code owners
beratbayram
pushed a commit
to beratbayram/workers-sdk
that referenced
this pull request
Jan 21, 2025
9 tasks
emily-shen
pushed a commit
that referenced
this pull request
Feb 10, 2025
* resolves #925 * fixes issue name * fix(create-cloudflare): update version from major to patch * Revert last 3 commits * fix(create-cloudflare): removed top-level await in next.config.ts * fix(create-cloudflare): typo fix * fix(create-cloudflare): changeset fix * fix(create-cloudflare): Update .changeset/famous-coats-admire.md Co-authored-by: Victor Berchet <[email protected]> * fix(create-cloudflare): Update .changeset/famous-coats-admire.md 2 * fix(create-cloudflare): Update .changeset/famous-coats-admire.md 3 Co-authored-by: Victor Berchet <[email protected]> * fix(create-cloudflare): pnpm fix on changeset --------- Co-authored-by: Berat BAYRAM <[email protected]> Co-authored-by: Victor Berchet <[email protected]> Co-authored-by: Carmen Popoviciu <[email protected]>
GregBrimble
pushed a commit
that referenced
this pull request
Feb 10, 2025
* resolves #925 * fixes issue name * fix(create-cloudflare): update version from major to patch * Revert last 3 commits * fix(create-cloudflare): removed top-level await in next.config.ts * fix(create-cloudflare): typo fix * fix(create-cloudflare): changeset fix * fix(create-cloudflare): Update .changeset/famous-coats-admire.md Co-authored-by: Victor Berchet <[email protected]> * fix(create-cloudflare): Update .changeset/famous-coats-admire.md 2 * fix(create-cloudflare): Update .changeset/famous-coats-admire.md 3 Co-authored-by: Victor Berchet <[email protected]> * fix(create-cloudflare): pnpm fix on changeset --------- Co-authored-by: Berat BAYRAM <[email protected]> Co-authored-by: Victor Berchet <[email protected]> Co-authored-by: Carmen Popoviciu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
[email protected]
Patch Changes
#924
3bdba63Thanks @threepointone! - fix: withwrangler init, test for existence ofpackage.json/tsconfig.json/.gitin the right locationsWhen running
wrangler.init, we look for the existence ofpackage.json, /tsconfig.json/.gitwhen deciding whether we should create them ourselves or not. Becausenamecan be a relative path, we had a bug where we don't starting look from the right directory. We also had a bug where we weren't even testing for the existence of the.gitdirectory correctly. This patch fixes that initial starting location, tests for.gitas a directory, and correctly decides when to create those files.