Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: wrangler pages dev hot reloading error on Next.js local development #3886

Closed
tengweiherr opened this issue Sep 1, 2023 · 3 comments · Fixed by #4877
Closed

🐛 BUG: wrangler pages dev hot reloading error on Next.js local development #3886

tengweiherr opened this issue Sep 1, 2023 · 3 comments · Fixed by #4877
Labels
bug Something that isn't working pages Relating to Pages

Comments

@tengweiherr
Copy link

tengweiherr commented Sep 1, 2023

Which Cloudflare product(s) does this pertain to?

Pages

What version(s) of the tool(s) are you using?

3.5.0 [Wrangler]

What version of Node are you using?

16.18.1

What operating system are you using?

Mac

Describe the Bug

I was following the local development guide of Next.js on @cloudflare/next-on-pages. The following is the summary:

  1. Enable Next.js pages local development in watch mode
    npx @cloudflare/next-on-pages --watch
  2. Then in a separate terminal run:
    npx wrangler pages dev .vercel/output/static --compatibility-flag=nodejs_compat

On every change in the directory, it does trigger the build. During every build, the files in .vercel/output will be removed and replaced by updated asset. The building process takes quite some time, resulting in the following error from the wrangler:

✘ [ERROR] Could not validate _routes.json at /Users/wteng/Desktop/web-app/.vercel/output/static: Error: ENOENT: no such file or directory, open '/Users/wteng/Desktop/web-app/.vercel/output/static/_routes.json'

▲ [WARNING] Falling back to the following _routes.json default: {

    "version": 1,
    "include": [
      "/*"
    ],
    "exclude": []
  }

/usr/local/lib/node_modules/wrangler/wrangler-dist/cli.js:30632
            throw a;
            ^

[Error: ENOENT: no such file or directory, scandir '/Users/wteng/Desktop/web-app/.vercel/output/static/_worker.js'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'scandir',
  path: '/Users/wteng/Desktop/web-app/.vercel/output/static/_worker.js'
}

I also tried npx wrangler pages dev --live-reload .vercel/output/static --compatibility-flag=nodejs_compat but still the result.

Expected result

It should work like a proper hot reloading application without error.

Please provide a link to a minimal reproduction

No response

@tengweiherr tengweiherr added the bug Something that isn't working label Sep 1, 2023
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Sep 1, 2023
@tengweiherr tengweiherr changed the title 🐛 BUG: wrangler pages dev 🐛 BUG: wrangler pages dev hot reloading error on Next.js local development Sep 1, 2023
@admah admah added the pages Relating to Pages label Sep 8, 2023
@ln-north
Copy link

ln-north commented Jan 23, 2024

When a process remains on port 8788, it is not a fundamental solution, but adding lsof -ti:8788 | xargs kill -9; can make development a bit easier.
(For example, lsof -ti:8788 | xargs kill -9; yarn pages:dev or lsof -ti:8788 | xargs kill -9; npx wrangler pages dev ... in package.json)

I hope this issue will be resolved.

magnusdahlstrand added a commit to magnusdahlstrand/workers-sdk that referenced this issue Jan 30, 2024
magnusdahlstrand added a commit to magnusdahlstrand/workers-sdk that referenced this issue Jan 30, 2024
petebacondarwin added a commit that referenced this issue Feb 2, 2024
#4877)

* [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* Update .changeset/hip-files-count.md

Co-authored-by: Pete Bacon Darwin <[email protected]>

* !fixup: [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* !fixup: [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

---------

Co-authored-by: Peter Bacon Darwin <[email protected]>
Co-authored-by: Pete Bacon Darwin <[email protected]>
@github-project-automation github-project-automation bot moved this from Untriaged to Done in workers-sdk Feb 2, 2024
lrapoport-cf pushed a commit that referenced this issue Feb 8, 2024
* ci: only deploy Workers when pushing to special branches (#4848)

Previously every push to `main` that contained changes to a Worker package would cause that Worker to be deploy "to production".
This meant that we had to be very careful about merging PRs that touch these Workers files.

Now production deployment is only run for a Worker on a push to its special deployment branch (e.g. `deploy-worker/playground-preview-worker`).
This allows us to land PRs to `main` and then collect up changes to release in a single go by updating the special deployment branch in a controlled way.
Moreover it is also easy to see what changes will be released by looking at the difference between `main` and the deployment branch for the Worker package directory.

The three workers in this repo now follow this pattern:

- edge-preview-authenticated-proxy
- format-errors
- playground-preview-worker

In addition, the Playground Preview Worker has end-to-end tests that are run on every push to the `main` branch, and also any PRs that have the "playground-worker" label.
For these tests the Worker is deployed to the testing environment before running the tests against this deployment.

* C3: bump `create-next-app` and handle new `next.config.mjs` defaults (#4863)

* bump create-next-app from 14.0.4 to 14.1.0

* C3: handle new next.config.mjs default files

* [wrangler] Support ai bindings in getBindingsProxy (#4869)

* Retain AI service binding from miniflare options

* Update changeset

* chore: bump `workerd` to `1.20240129.0` (#4874)

* [C3] Bump create-vue from 3.9.1 to 3.9.2 in /packages/create-cloudflare/src/frameworks (#4870)

* [C3] Bump create-vue in /packages/create-cloudflare/src/frameworks

Bumps [create-vue](https://github.com/vuejs/create-vue) from 3.9.1 to 3.9.2.
- [Release notes](https://github.com/vuejs/create-vue/releases)
- [Commits](vuejs/create-vue@v3.9.1...v3.9.2)

---
updated-dependencies:
- dependency-name: create-vue
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* Exclude standardPricingWarning from dryrun (#4880)

* Exclude standardPricingWarning from dryrun

That way we do not need authentication for dryrun, again.

* fixup! Exclude standardPricingWarning from dryrun

* fixup! Exclude standardPricingWarning from dryrun

---------

Co-authored-by: petero-dk <[email protected]>

* Implements Python support in miniflare. (#4873)

* Fix changesets (#4885)

* fix dario-piotrowicz's changesets

* fix existing C3 changesets and amend the changeset text in the creation logic

* Version Packages (#4854)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [C3] Bump create-qwik from 1.4.2 to 1.4.3 in /packages/create-cloudflare/src/frameworks (#4881)

* [C3] Bump create-qwik in /packages/create-cloudflare/src/frameworks

Bumps [create-qwik](https://github.com/BuilderIO/qwik/tree/HEAD/packages/create-qwik) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/BuilderIO/qwik/releases)
- [Commits](https://github.com/BuilderIO/qwik/commits/v1.4.3/packages/create-qwik)

---
updated-dependencies:
- dependency-name: create-qwik
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* [wrangler] fix: listen on loopback for wrangler dev port check and login (#4830)

The `wrangler dev` port availability check triggers a firewall prompt on
macOS while it briefly opens and closes listeners. The OAuth callback
server from `wrangler login` has the same issue.

Fix both cases by listening on the loopback address only by default.

Fixed some new test failures by using locally available IP addresses:

    wrangler:test:   ● wrangler dev › ip › should use to `ip` from `wrangler.toml`, if available
    wrangler:test:     listen EADDRNOTAVAIL: address not available 1.2.3.4:8787
    wrangler:test:
    wrangler:test:   ● wrangler dev › ip › should use --ip command line arg, if provided
    wrangler:test:     listen EADDRNOTAVAIL: address not available 5.6.7.8:8787

Relates to #4430

* remove outdated and no longer valid miniflare development section from CONTRIBUTING.md (#4893)

* [C3] Bump @angular/create from 17.1.1 to 17.1.2 in /packages/create-cloudflare/src/frameworks (#4892)

* [C3] Bump @angular/create in /packages/create-cloudflare/src/frameworks

Bumps [@angular/create](https://github.com/angular/angular-cli) from 17.1.1 to 17.1.2.
- [Release notes](https://github.com/angular/angular-cli/releases)
- [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md)
- [Commits](angular/angular-cli@17.1.1...17.1.2)

---
updated-dependencies:
- dependency-name: "@angular/create"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* [Stream] WebRTC Template Improvements (#4157)

* Add port numbers to fix stackblitz automatic startup

* Pull the variables up and show clear instructions

* fixup! Pull the variables up and show clear instructions

---------

Co-authored-by: Peter Bacon Darwin <[email protected]>

* fix: return 4xx error from playground preview worker on invalid tokens (#4904)

Previously, we were passing user-controllable token inputs
(`X-CF-Token` header, `user` search param, `token` cookie) directly to
the `DurableObjectNamespace#idFromString()` function. This validated
the token to be a valid Durable Object ID, but threw a reportable
`TypeError`, generating a 500 response and increasing the errored
request count. This is a user error, so shouldn't be reported. This
change wraps calls to `idFromString()` inside `try`/`catch`es, and
re-throws non-reportable user errors that generate 4xx responses.
We could just validate that the tokens were 64 hex digits before
calling `idFromString()`, but this approach ensures the IDs are for
the `UserSession` object by validating the signature encoded in the
ID too.

* chore: rename deprecated Vitest `TestContext.meta` properties to `TestContext.task` (#4897)

This is a precursor to updating to latest Vitest.

* [wrangler] fix: stop rebuild attempts when sources are missing (#3886) (#4877)

* [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* Update .changeset/hip-files-count.md

Co-authored-by: Pete Bacon Darwin <[email protected]>

* !fixup: [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* !fixup: [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

---------

Co-authored-by: Peter Bacon Darwin <[email protected]>
Co-authored-by: Pete Bacon Darwin <[email protected]>

* [C3] Bump create-remix from 2.5.1 to 2.6.0 in /packages/create-cloudflare/src/frameworks (#4903)

* [C3] Bump create-remix in /packages/create-cloudflare/src/frameworks

Bumps [create-remix](https://github.com/remix-run/remix/tree/HEAD/packages/create-remix) from 2.5.1 to 2.6.0.
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/create-remix/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/[email protected]/packages/create-remix)

---
updated-dependencies:
- dependency-name: create-remix
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* fix: ensure that the Pages dev proxy server does not change the Host header (#4888)

* fix: ensure that the Pages dev proxy server does not change the Host header

Previously, when configuring `wrangler pages dev` to use a proxy to a 3rd party dev server,
the proxy would replace the Host header, resulting in problems at the dev server if it was
checking for cross-site scripting attacks.

Now the proxy server passes through the Host header unaltered making it invisible to the
3rd party dev server.

Fixes #4799

* fixup! fix: ensure that the Pages dev proxy server does not change the Host header

* fixup! fix: ensure that the Pages dev proxy server does not change the Host header

* fixup! fix: ensure that the Pages dev proxy server does not change the Host header

* fix: fallback to returning stack trace if `format-errors` broken (#4908)

* expose cf object from Miniflare instances (#4905)

* expose cf object from Miniflare instances

---------

Co-authored-by: MrBBot <[email protected]>

* Add a `ctx` field to the `getBindingsProxy` result (#4922)

* split get-bindings-proxy fixture tests in multiple files

* add ctx to getBindingsProxy

* add ctx tests to get-bindings-proxy fixture

---------

Co-authored-by: MrBBot <[email protected]>

* fix(d1): intercept and stringify errors thrown in --json mode (#4872)

* fix(d1): intercept and stringify errors thrown in --json mode

* fix: add light parsing on d1 execute error message

* add test

* wip

* implement JsonFriendlyFatalError

* address PR feedback

* fix: don't report invalid `format-errors` input (#4911)

* [D1] Add user friendly D1 validation error messages for `dev --remote` and `deploy` (#4914)

* chore: refactor user friendly errors and add 10063 code handling

* chore: add user friendly error message to deployments

* chore: lint

* chore: cleanup directory

* chore: fix remote error handling

* chore: add patch change set

* chore: move ABORT_ERR logic out of the user friendly error handler

* chore: fix syntax

* Update .changeset/fair-shoes-melt.md

Co-authored-by: Pete Bacon Darwin <[email protected]>

---------

Co-authored-by: Pete Bacon Darwin <[email protected]>

* [D1] teach wrangler how to fetch insights about D1's queries (#4909)

* [D1] teach wrangler how to fetch insights about D1's queries

* add options for sorting and number of results

* add a means of filtering the datetime geq/leq

* add more options, fix tests

* add wrangler banner, add warning text

* add changeset

* rename last to timePeriod

* use string format over numbers as >1mo's data could be possible

* Update red-icons-flow.md

* make it possible to order by count

* Update red-icons-flow.md

* PR feedback

* Update .changeset/red-icons-flow.md

Co-authored-by: Pete Bacon Darwin <[email protected]>

* address PR feedback

---------

Co-authored-by: Pete Bacon Darwin <[email protected]>

* [wrangler] test: fix E2E tests (#4907)

* ci: ensure E2E tests failures not reported as successes

#4458 accidentally left `continue-on-error: true` in the workflow.
This meant that E2E test failures weren't reported as check failures.

* test: remove redundant `deploy.test.ts` E2E test

This test was a strict subset of `deployments.test.ts`, and wasn't
providing any additional value.

* test: remove standard pricing warning from E2E test output

This warning may not be shown if an account has opted-in to standard
pricing. This change normalises output to remove it, meaning tests
can be run on any account, regardless of opt-in state.

* test: update format of writing logs message in E2E tests

* test: use `fallback` instead of `default` in E2E tests

#4571 updated the message logged in non-interactive contexts for
default values to use the word `fallback` instead of `default`.

* fix: ensure `--log-level` argument applied immediately

Some messages were being logged before the `--log-level` argument was
applied. In particular, this meant the "writing logs to" message at
`debug` level, was not output when using `--log-level=debug`.

* test: improve reliability of `dev.test.ts` E2E test

This change makes a few improvements to `dev.test.ts`:

- Shorter timeouts for `fetch()` retries
- Replaces `get-port` with native port `0` implementation
- Waits for stdout handlers to be registered before starting
  `wrangler dev`
- Ignores errors if we failed to find a proccess to kill
  (assumes the process was already killed)

* fix: throw `UserError`s for R2 object/bucket not-found errors

These errors should not be reported to Sentry.

* global install

* Ensure internal workers listen on ipv4 only

* shorter timeouts


---------

Co-authored-by: Samuel Macleod <[email protected]>

* Python support (#4901)

* Implements wrangler deploy/dev support for Python.

* Migrate to `--no-bundle` approach

* Basic support for `requirements.txt`

* address review comments

* Strip package versions

* Support deploying

* Address comments

* Fix tests

---------

Co-authored-by: Dominik Picheta <[email protected]>

* Version Packages (#4891)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [C3] Add `getBindingsProxy` support to qwik template (#4927)

* Split package.json update into multiple phases

* Add getBindingsProxy to qwik template

* Add support for testing dev scripts in c3 e2e tests

* Refactor framework e2e verification helpers

* Add support for verifying build script in framework e2es

* Refactor e2e helpers

* Refactor workers e2e tests to re-align with frameworks tests

* Refactor RunnerConfig in e2e tests

* Fixing cli e2e tests

* changeset

* remove leftover test value

* Fix issue with npm tests & fix e2e logging

* Addressing PR feedback

* [playground-preview-worker] fix: don't report invalid upload input (#4937)

* fix: don't report invalid `edge-preview-authenticated-proxy` URLs (#4939)

* [D1] print wrangler banner at the start of every D1 command (#4938)

* fix: make the entrypoint optional for the `types` command (#4931)

---------

Co-authored-by: MrBBot <[email protected]>

* add a `cf` field to the `getBindingsProxy` result (#4926)


---------

Co-authored-by: James Culveyhouse <[email protected]>

* Improve DX with `node:*` modules (#4499)

* Turn node build failures into warnings

* Allow files to suppress warnings for specific modules

* Remove comment-based allow-listing

* Add changeset

* Update .changeset/chatty-balloons-impress.md

Co-authored-by: James M Snell <[email protected]>

* Pass through `defineNavigatorUserAgent`

* Add tests

* lockfile

* Linting

* fix tests

---------

Co-authored-by: James M Snell <[email protected]>

* improve(r2): Update Sippy endpoint request payloads to match new schema (#4928)

* fix(r2): update Sippy API request payloads

* improve(r2): rename sippy flags for clarity

* improve(r2): stricter existence in Sippy

* [C3] Bump create-qwik from 1.4.3 to 1.4.4 in /packages/create-cloudflare/src/frameworks (#4935)

* [C3] Bump create-qwik in /packages/create-cloudflare/src/frameworks

Bumps [create-qwik](https://github.com/BuilderIO/qwik/tree/HEAD/packages/create-qwik) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/BuilderIO/qwik/releases)
- [Commits](https://github.com/BuilderIO/qwik/commits/v1.4.4/packages/create-qwik)

---
updated-dependencies:
- dependency-name: create-qwik
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* fix: allow `port` option to be specified with `unstable_dev()` (#4953)

* Extend error handling of proxy request errors in ProxyWorker (#4867)

* ignore stale proxy errors

* attempt to recover from ProxyWorker fetch errors
by requeuing the request (only if it is GET or HEAD)

* add test

* add changeset

* refactor to flatten nested if-else blocks

* requeue request for retry at front of queue

* sort batch of requests in queue by order of arrival

* Revert "sort batch of requests in queue by order of arrival"

This reverts commit 3329f19.

* Revert "requeue request for retry at front of queue"

This reverts commit f0377b7.

* prioritise requests being retried
over requests being proxied for the first time

* better comments

* update changeset to match recommeded format

* Update five-cooks-share.md (#4956)

* Version Packages (#4934)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Pete Bacon Darwin <[email protected]>
Co-authored-by: Dario Piotrowicz <[email protected]>
Co-authored-by: James Culveyhouse <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>
Co-authored-by: petero-dk <[email protected]>
Co-authored-by: Dominik Picheta <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Peter Wu <[email protected]>
Co-authored-by: Taylor Smith <[email protected]>
Co-authored-by: Peter Bacon Darwin <[email protected]>
Co-authored-by: Magnus Dahlstrand <[email protected]>
Co-authored-by: Max Rozen <[email protected]>
Co-authored-by: Nora Söderlund <[email protected]>
Co-authored-by: Samuel Macleod <[email protected]>
Co-authored-by: Dominik Picheta <[email protected]>
Co-authored-by: James M Snell <[email protected]>
Co-authored-by: Siddhant <[email protected]>
Co-authored-by: Rahul Sethi <[email protected]>
lrapoport-cf pushed a commit that referenced this issue Feb 8, 2024
* ci: only deploy Workers when pushing to special branches (#4848)

Previously every push to `main` that contained changes to a Worker package would cause that Worker to be deploy "to production".
This meant that we had to be very careful about merging PRs that touch these Workers files.

Now production deployment is only run for a Worker on a push to its special deployment branch (e.g. `deploy-worker/playground-preview-worker`).
This allows us to land PRs to `main` and then collect up changes to release in a single go by updating the special deployment branch in a controlled way.
Moreover it is also easy to see what changes will be released by looking at the difference between `main` and the deployment branch for the Worker package directory.

The three workers in this repo now follow this pattern:

- edge-preview-authenticated-proxy
- format-errors
- playground-preview-worker

In addition, the Playground Preview Worker has end-to-end tests that are run on every push to the `main` branch, and also any PRs that have the "playground-worker" label.
For these tests the Worker is deployed to the testing environment before running the tests against this deployment.

* C3: bump `create-next-app` and handle new `next.config.mjs` defaults (#4863)

* bump create-next-app from 14.0.4 to 14.1.0

* C3: handle new next.config.mjs default files

* [wrangler] Support ai bindings in getBindingsProxy (#4869)

* Retain AI service binding from miniflare options

* Update changeset

* chore: bump `workerd` to `1.20240129.0` (#4874)

* [C3] Bump create-vue from 3.9.1 to 3.9.2 in /packages/create-cloudflare/src/frameworks (#4870)

* [C3] Bump create-vue in /packages/create-cloudflare/src/frameworks

Bumps [create-vue](https://github.com/vuejs/create-vue) from 3.9.1 to 3.9.2.
- [Release notes](https://github.com/vuejs/create-vue/releases)
- [Commits](vuejs/create-vue@v3.9.1...v3.9.2)

---
updated-dependencies:
- dependency-name: create-vue
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* Exclude standardPricingWarning from dryrun (#4880)

* Exclude standardPricingWarning from dryrun

That way we do not need authentication for dryrun, again.

* fixup! Exclude standardPricingWarning from dryrun

* fixup! Exclude standardPricingWarning from dryrun

---------

Co-authored-by: petero-dk <[email protected]>

* Implements Python support in miniflare. (#4873)

* Fix changesets (#4885)

* fix dario-piotrowicz's changesets

* fix existing C3 changesets and amend the changeset text in the creation logic

* Version Packages (#4854)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [C3] Bump create-qwik from 1.4.2 to 1.4.3 in /packages/create-cloudflare/src/frameworks (#4881)

* [C3] Bump create-qwik in /packages/create-cloudflare/src/frameworks

Bumps [create-qwik](https://github.com/BuilderIO/qwik/tree/HEAD/packages/create-qwik) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/BuilderIO/qwik/releases)
- [Commits](https://github.com/BuilderIO/qwik/commits/v1.4.3/packages/create-qwik)

---
updated-dependencies:
- dependency-name: create-qwik
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* [wrangler] fix: listen on loopback for wrangler dev port check and login (#4830)

The `wrangler dev` port availability check triggers a firewall prompt on
macOS while it briefly opens and closes listeners. The OAuth callback
server from `wrangler login` has the same issue.

Fix both cases by listening on the loopback address only by default.

Fixed some new test failures by using locally available IP addresses:

    wrangler:test:   ● wrangler dev › ip › should use to `ip` from `wrangler.toml`, if available
    wrangler:test:     listen EADDRNOTAVAIL: address not available 1.2.3.4:8787
    wrangler:test:
    wrangler:test:   ● wrangler dev › ip › should use --ip command line arg, if provided
    wrangler:test:     listen EADDRNOTAVAIL: address not available 5.6.7.8:8787

Relates to #4430

* remove outdated and no longer valid miniflare development section from CONTRIBUTING.md (#4893)

* [C3] Bump @angular/create from 17.1.1 to 17.1.2 in /packages/create-cloudflare/src/frameworks (#4892)

* [C3] Bump @angular/create in /packages/create-cloudflare/src/frameworks

Bumps [@angular/create](https://github.com/angular/angular-cli) from 17.1.1 to 17.1.2.
- [Release notes](https://github.com/angular/angular-cli/releases)
- [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md)
- [Commits](angular/angular-cli@17.1.1...17.1.2)

---
updated-dependencies:
- dependency-name: "@angular/create"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* [Stream] WebRTC Template Improvements (#4157)

* Add port numbers to fix stackblitz automatic startup

* Pull the variables up and show clear instructions

* fixup! Pull the variables up and show clear instructions

---------

Co-authored-by: Peter Bacon Darwin <[email protected]>

* fix: return 4xx error from playground preview worker on invalid tokens (#4904)

Previously, we were passing user-controllable token inputs
(`X-CF-Token` header, `user` search param, `token` cookie) directly to
the `DurableObjectNamespace#idFromString()` function. This validated
the token to be a valid Durable Object ID, but threw a reportable
`TypeError`, generating a 500 response and increasing the errored
request count. This is a user error, so shouldn't be reported. This
change wraps calls to `idFromString()` inside `try`/`catch`es, and
re-throws non-reportable user errors that generate 4xx responses.
We could just validate that the tokens were 64 hex digits before
calling `idFromString()`, but this approach ensures the IDs are for
the `UserSession` object by validating the signature encoded in the
ID too.

* chore: rename deprecated Vitest `TestContext.meta` properties to `TestContext.task` (#4897)

This is a precursor to updating to latest Vitest.

* [wrangler] fix: stop rebuild attempts when sources are missing (#3886) (#4877)

* [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* Update .changeset/hip-files-count.md

Co-authored-by: Pete Bacon Darwin <[email protected]>

* !fixup: [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* !fixup: [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

---------

Co-authored-by: Peter Bacon Darwin <[email protected]>
Co-authored-by: Pete Bacon Darwin <[email protected]>

* [C3] Bump create-remix from 2.5.1 to 2.6.0 in /packages/create-cloudflare/src/frameworks (#4903)

* [C3] Bump create-remix in /packages/create-cloudflare/src/frameworks

Bumps [create-remix](https://github.com/remix-run/remix/tree/HEAD/packages/create-remix) from 2.5.1 to 2.6.0.
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/create-remix/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/[email protected]/packages/create-remix)

---
updated-dependencies:
- dependency-name: create-remix
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* fix: ensure that the Pages dev proxy server does not change the Host header (#4888)

* fix: ensure that the Pages dev proxy server does not change the Host header

Previously, when configuring `wrangler pages dev` to use a proxy to a 3rd party dev server,
the proxy would replace the Host header, resulting in problems at the dev server if it was
checking for cross-site scripting attacks.

Now the proxy server passes through the Host header unaltered making it invisible to the
3rd party dev server.

Fixes #4799

* fixup! fix: ensure that the Pages dev proxy server does not change the Host header

* fixup! fix: ensure that the Pages dev proxy server does not change the Host header

* fixup! fix: ensure that the Pages dev proxy server does not change the Host header

* fix: fallback to returning stack trace if `format-errors` broken (#4908)

* expose cf object from Miniflare instances (#4905)

* expose cf object from Miniflare instances

---------

Co-authored-by: MrBBot <[email protected]>

* Add a `ctx` field to the `getBindingsProxy` result (#4922)

* split get-bindings-proxy fixture tests in multiple files

* add ctx to getBindingsProxy

* add ctx tests to get-bindings-proxy fixture

---------

Co-authored-by: MrBBot <[email protected]>

* fix(d1): intercept and stringify errors thrown in --json mode (#4872)

* fix(d1): intercept and stringify errors thrown in --json mode

* fix: add light parsing on d1 execute error message

* add test

* wip

* implement JsonFriendlyFatalError

* address PR feedback

* fix: don't report invalid `format-errors` input (#4911)

* [D1] Add user friendly D1 validation error messages for `dev --remote` and `deploy` (#4914)

* chore: refactor user friendly errors and add 10063 code handling

* chore: add user friendly error message to deployments

* chore: lint

* chore: cleanup directory

* chore: fix remote error handling

* chore: add patch change set

* chore: move ABORT_ERR logic out of the user friendly error handler

* chore: fix syntax

* Update .changeset/fair-shoes-melt.md

Co-authored-by: Pete Bacon Darwin <[email protected]>

---------

Co-authored-by: Pete Bacon Darwin <[email protected]>

* [D1] teach wrangler how to fetch insights about D1's queries (#4909)

* [D1] teach wrangler how to fetch insights about D1's queries

* add options for sorting and number of results

* add a means of filtering the datetime geq/leq

* add more options, fix tests

* add wrangler banner, add warning text

* add changeset

* rename last to timePeriod

* use string format over numbers as >1mo's data could be possible

* Update red-icons-flow.md

* make it possible to order by count

* Update red-icons-flow.md

* PR feedback

* Update .changeset/red-icons-flow.md

Co-authored-by: Pete Bacon Darwin <[email protected]>

* address PR feedback

---------

Co-authored-by: Pete Bacon Darwin <[email protected]>

* [wrangler] test: fix E2E tests (#4907)

* ci: ensure E2E tests failures not reported as successes

#4458 accidentally left `continue-on-error: true` in the workflow.
This meant that E2E test failures weren't reported as check failures.

* test: remove redundant `deploy.test.ts` E2E test

This test was a strict subset of `deployments.test.ts`, and wasn't
providing any additional value.

* test: remove standard pricing warning from E2E test output

This warning may not be shown if an account has opted-in to standard
pricing. This change normalises output to remove it, meaning tests
can be run on any account, regardless of opt-in state.

* test: update format of writing logs message in E2E tests

* test: use `fallback` instead of `default` in E2E tests

#4571 updated the message logged in non-interactive contexts for
default values to use the word `fallback` instead of `default`.

* fix: ensure `--log-level` argument applied immediately

Some messages were being logged before the `--log-level` argument was
applied. In particular, this meant the "writing logs to" message at
`debug` level, was not output when using `--log-level=debug`.

* test: improve reliability of `dev.test.ts` E2E test

This change makes a few improvements to `dev.test.ts`:

- Shorter timeouts for `fetch()` retries
- Replaces `get-port` with native port `0` implementation
- Waits for stdout handlers to be registered before starting
  `wrangler dev`
- Ignores errors if we failed to find a proccess to kill
  (assumes the process was already killed)

* fix: throw `UserError`s for R2 object/bucket not-found errors

These errors should not be reported to Sentry.

* global install

* Ensure internal workers listen on ipv4 only

* shorter timeouts


---------

Co-authored-by: Samuel Macleod <[email protected]>

* Python support (#4901)

* Implements wrangler deploy/dev support for Python.

* Migrate to `--no-bundle` approach

* Basic support for `requirements.txt`

* address review comments

* Strip package versions

* Support deploying

* Address comments

* Fix tests

---------

Co-authored-by: Dominik Picheta <[email protected]>

* Version Packages (#4891)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [C3] Add `getBindingsProxy` support to qwik template (#4927)

* Split package.json update into multiple phases

* Add getBindingsProxy to qwik template

* Add support for testing dev scripts in c3 e2e tests

* Refactor framework e2e verification helpers

* Add support for verifying build script in framework e2es

* Refactor e2e helpers

* Refactor workers e2e tests to re-align with frameworks tests

* Refactor RunnerConfig in e2e tests

* Fixing cli e2e tests

* changeset

* remove leftover test value

* Fix issue with npm tests & fix e2e logging

* Addressing PR feedback

* [playground-preview-worker] fix: don't report invalid upload input (#4937)

* fix: don't report invalid `edge-preview-authenticated-proxy` URLs (#4939)

* [D1] print wrangler banner at the start of every D1 command (#4938)

* fix: make the entrypoint optional for the `types` command (#4931)

---------

Co-authored-by: MrBBot <[email protected]>

* add a `cf` field to the `getBindingsProxy` result (#4926)


---------

Co-authored-by: James Culveyhouse <[email protected]>

* Improve DX with `node:*` modules (#4499)

* Turn node build failures into warnings

* Allow files to suppress warnings for specific modules

* Remove comment-based allow-listing

* Add changeset

* Update .changeset/chatty-balloons-impress.md

Co-authored-by: James M Snell <[email protected]>

* Pass through `defineNavigatorUserAgent`

* Add tests

* lockfile

* Linting

* fix tests

---------

Co-authored-by: James M Snell <[email protected]>

* improve(r2): Update Sippy endpoint request payloads to match new schema (#4928)

* fix(r2): update Sippy API request payloads

* improve(r2): rename sippy flags for clarity

* improve(r2): stricter existence in Sippy

* [C3] Bump create-qwik from 1.4.3 to 1.4.4 in /packages/create-cloudflare/src/frameworks (#4935)

* [C3] Bump create-qwik in /packages/create-cloudflare/src/frameworks

Bumps [create-qwik](https://github.com/BuilderIO/qwik/tree/HEAD/packages/create-qwik) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/BuilderIO/qwik/releases)
- [Commits](https://github.com/BuilderIO/qwik/commits/v1.4.4/packages/create-qwik)

---
updated-dependencies:
- dependency-name: create-qwik
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* fix: allow `port` option to be specified with `unstable_dev()` (#4953)

* Extend error handling of proxy request errors in ProxyWorker (#4867)

* ignore stale proxy errors

* attempt to recover from ProxyWorker fetch errors
by requeuing the request (only if it is GET or HEAD)

* add test

* add changeset

* refactor to flatten nested if-else blocks

* requeue request for retry at front of queue

* sort batch of requests in queue by order of arrival

* Revert "sort batch of requests in queue by order of arrival"

This reverts commit 3329f19.

* Revert "requeue request for retry at front of queue"

This reverts commit f0377b7.

* prioritise requests being retried
over requests being proxied for the first time

* better comments

* update changeset to match recommeded format

* Update five-cooks-share.md (#4956)

* Version Packages (#4934)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Pete Bacon Darwin <[email protected]>
Co-authored-by: Dario Piotrowicz <[email protected]>
Co-authored-by: James Culveyhouse <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>
Co-authored-by: petero-dk <[email protected]>
Co-authored-by: Dominik Picheta <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Peter Wu <[email protected]>
Co-authored-by: Taylor Smith <[email protected]>
Co-authored-by: Peter Bacon Darwin <[email protected]>
Co-authored-by: Magnus Dahlstrand <[email protected]>
Co-authored-by: Max Rozen <[email protected]>
Co-authored-by: Nora Söderlund <[email protected]>
Co-authored-by: Samuel Macleod <[email protected]>
Co-authored-by: Dominik Picheta <[email protected]>
Co-authored-by: James M Snell <[email protected]>
Co-authored-by: Siddhant <[email protected]>
Co-authored-by: Rahul Sethi <[email protected]>
lrapoport-cf pushed a commit that referenced this issue Feb 8, 2024
* ci: only deploy Workers when pushing to special branches (#4848)

Previously every push to `main` that contained changes to a Worker package would cause that Worker to be deploy "to production".
This meant that we had to be very careful about merging PRs that touch these Workers files.

Now production deployment is only run for a Worker on a push to its special deployment branch (e.g. `deploy-worker/playground-preview-worker`).
This allows us to land PRs to `main` and then collect up changes to release in a single go by updating the special deployment branch in a controlled way.
Moreover it is also easy to see what changes will be released by looking at the difference between `main` and the deployment branch for the Worker package directory.

The three workers in this repo now follow this pattern:

- edge-preview-authenticated-proxy
- format-errors
- playground-preview-worker

In addition, the Playground Preview Worker has end-to-end tests that are run on every push to the `main` branch, and also any PRs that have the "playground-worker" label.
For these tests the Worker is deployed to the testing environment before running the tests against this deployment.

* C3: bump `create-next-app` and handle new `next.config.mjs` defaults (#4863)

* bump create-next-app from 14.0.4 to 14.1.0

* C3: handle new next.config.mjs default files

* [wrangler] Support ai bindings in getBindingsProxy (#4869)

* Retain AI service binding from miniflare options

* Update changeset

* chore: bump `workerd` to `1.20240129.0` (#4874)

* [C3] Bump create-vue from 3.9.1 to 3.9.2 in /packages/create-cloudflare/src/frameworks (#4870)

* [C3] Bump create-vue in /packages/create-cloudflare/src/frameworks

Bumps [create-vue](https://github.com/vuejs/create-vue) from 3.9.1 to 3.9.2.
- [Release notes](https://github.com/vuejs/create-vue/releases)
- [Commits](vuejs/create-vue@v3.9.1...v3.9.2)

---
updated-dependencies:
- dependency-name: create-vue
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* Exclude standardPricingWarning from dryrun (#4880)

* Exclude standardPricingWarning from dryrun

That way we do not need authentication for dryrun, again.

* fixup! Exclude standardPricingWarning from dryrun

* fixup! Exclude standardPricingWarning from dryrun

---------

Co-authored-by: petero-dk <[email protected]>

* Implements Python support in miniflare. (#4873)

* Fix changesets (#4885)

* fix dario-piotrowicz's changesets

* fix existing C3 changesets and amend the changeset text in the creation logic

* Version Packages (#4854)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [C3] Bump create-qwik from 1.4.2 to 1.4.3 in /packages/create-cloudflare/src/frameworks (#4881)

* [C3] Bump create-qwik in /packages/create-cloudflare/src/frameworks

Bumps [create-qwik](https://github.com/BuilderIO/qwik/tree/HEAD/packages/create-qwik) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/BuilderIO/qwik/releases)
- [Commits](https://github.com/BuilderIO/qwik/commits/v1.4.3/packages/create-qwik)

---
updated-dependencies:
- dependency-name: create-qwik
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* [wrangler] fix: listen on loopback for wrangler dev port check and login (#4830)

The `wrangler dev` port availability check triggers a firewall prompt on
macOS while it briefly opens and closes listeners. The OAuth callback
server from `wrangler login` has the same issue.

Fix both cases by listening on the loopback address only by default.

Fixed some new test failures by using locally available IP addresses:

    wrangler:test:   ● wrangler dev › ip › should use to `ip` from `wrangler.toml`, if available
    wrangler:test:     listen EADDRNOTAVAIL: address not available 1.2.3.4:8787
    wrangler:test:
    wrangler:test:   ● wrangler dev › ip › should use --ip command line arg, if provided
    wrangler:test:     listen EADDRNOTAVAIL: address not available 5.6.7.8:8787

Relates to #4430

* remove outdated and no longer valid miniflare development section from CONTRIBUTING.md (#4893)

* [C3] Bump @angular/create from 17.1.1 to 17.1.2 in /packages/create-cloudflare/src/frameworks (#4892)

* [C3] Bump @angular/create in /packages/create-cloudflare/src/frameworks

Bumps [@angular/create](https://github.com/angular/angular-cli) from 17.1.1 to 17.1.2.
- [Release notes](https://github.com/angular/angular-cli/releases)
- [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md)
- [Commits](angular/angular-cli@17.1.1...17.1.2)

---
updated-dependencies:
- dependency-name: "@angular/create"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* [Stream] WebRTC Template Improvements (#4157)

* Add port numbers to fix stackblitz automatic startup

* Pull the variables up and show clear instructions

* fixup! Pull the variables up and show clear instructions

---------

Co-authored-by: Peter Bacon Darwin <[email protected]>

* fix: return 4xx error from playground preview worker on invalid tokens (#4904)

Previously, we were passing user-controllable token inputs
(`X-CF-Token` header, `user` search param, `token` cookie) directly to
the `DurableObjectNamespace#idFromString()` function. This validated
the token to be a valid Durable Object ID, but threw a reportable
`TypeError`, generating a 500 response and increasing the errored
request count. This is a user error, so shouldn't be reported. This
change wraps calls to `idFromString()` inside `try`/`catch`es, and
re-throws non-reportable user errors that generate 4xx responses.
We could just validate that the tokens were 64 hex digits before
calling `idFromString()`, but this approach ensures the IDs are for
the `UserSession` object by validating the signature encoded in the
ID too.

* chore: rename deprecated Vitest `TestContext.meta` properties to `TestContext.task` (#4897)

This is a precursor to updating to latest Vitest.

* [wrangler] fix: stop rebuild attempts when sources are missing (#3886) (#4877)

* [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* fixup! [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* Update .changeset/hip-files-count.md

Co-authored-by: Pete Bacon Darwin <[email protected]>

* !fixup: [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

* !fixup: [wrangler] fix: stop rebuild attempts when sources are missing (#3886)

---------

Co-authored-by: Peter Bacon Darwin <[email protected]>
Co-authored-by: Pete Bacon Darwin <[email protected]>

* [C3] Bump create-remix from 2.5.1 to 2.6.0 in /packages/create-cloudflare/src/frameworks (#4903)

* [C3] Bump create-remix in /packages/create-cloudflare/src/frameworks

Bumps [create-remix](https://github.com/remix-run/remix/tree/HEAD/packages/create-remix) from 2.5.1 to 2.6.0.
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/create-remix/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/[email protected]/packages/create-remix)

---
updated-dependencies:
- dependency-name: create-remix
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* fix: ensure that the Pages dev proxy server does not change the Host header (#4888)

* fix: ensure that the Pages dev proxy server does not change the Host header

Previously, when configuring `wrangler pages dev` to use a proxy to a 3rd party dev server,
the proxy would replace the Host header, resulting in problems at the dev server if it was
checking for cross-site scripting attacks.

Now the proxy server passes through the Host header unaltered making it invisible to the
3rd party dev server.

Fixes #4799

* fixup! fix: ensure that the Pages dev proxy server does not change the Host header

* fixup! fix: ensure that the Pages dev proxy server does not change the Host header

* fixup! fix: ensure that the Pages dev proxy server does not change the Host header

* fix: fallback to returning stack trace if `format-errors` broken (#4908)

* expose cf object from Miniflare instances (#4905)

* expose cf object from Miniflare instances

---------

Co-authored-by: MrBBot <[email protected]>

* Add a `ctx` field to the `getBindingsProxy` result (#4922)

* split get-bindings-proxy fixture tests in multiple files

* add ctx to getBindingsProxy

* add ctx tests to get-bindings-proxy fixture

---------

Co-authored-by: MrBBot <[email protected]>

* fix(d1): intercept and stringify errors thrown in --json mode (#4872)

* fix(d1): intercept and stringify errors thrown in --json mode

* fix: add light parsing on d1 execute error message

* add test

* wip

* implement JsonFriendlyFatalError

* address PR feedback

* fix: don't report invalid `format-errors` input (#4911)

* [D1] Add user friendly D1 validation error messages for `dev --remote` and `deploy` (#4914)

* chore: refactor user friendly errors and add 10063 code handling

* chore: add user friendly error message to deployments

* chore: lint

* chore: cleanup directory

* chore: fix remote error handling

* chore: add patch change set

* chore: move ABORT_ERR logic out of the user friendly error handler

* chore: fix syntax

* Update .changeset/fair-shoes-melt.md

Co-authored-by: Pete Bacon Darwin <[email protected]>

---------

Co-authored-by: Pete Bacon Darwin <[email protected]>

* [D1] teach wrangler how to fetch insights about D1's queries (#4909)

* [D1] teach wrangler how to fetch insights about D1's queries

* add options for sorting and number of results

* add a means of filtering the datetime geq/leq

* add more options, fix tests

* add wrangler banner, add warning text

* add changeset

* rename last to timePeriod

* use string format over numbers as >1mo's data could be possible

* Update red-icons-flow.md

* make it possible to order by count

* Update red-icons-flow.md

* PR feedback

* Update .changeset/red-icons-flow.md

Co-authored-by: Pete Bacon Darwin <[email protected]>

* address PR feedback

---------

Co-authored-by: Pete Bacon Darwin <[email protected]>

* [wrangler] test: fix E2E tests (#4907)

* ci: ensure E2E tests failures not reported as successes

#4458 accidentally left `continue-on-error: true` in the workflow.
This meant that E2E test failures weren't reported as check failures.

* test: remove redundant `deploy.test.ts` E2E test

This test was a strict subset of `deployments.test.ts`, and wasn't
providing any additional value.

* test: remove standard pricing warning from E2E test output

This warning may not be shown if an account has opted-in to standard
pricing. This change normalises output to remove it, meaning tests
can be run on any account, regardless of opt-in state.

* test: update format of writing logs message in E2E tests

* test: use `fallback` instead of `default` in E2E tests

#4571 updated the message logged in non-interactive contexts for
default values to use the word `fallback` instead of `default`.

* fix: ensure `--log-level` argument applied immediately

Some messages were being logged before the `--log-level` argument was
applied. In particular, this meant the "writing logs to" message at
`debug` level, was not output when using `--log-level=debug`.

* test: improve reliability of `dev.test.ts` E2E test

This change makes a few improvements to `dev.test.ts`:

- Shorter timeouts for `fetch()` retries
- Replaces `get-port` with native port `0` implementation
- Waits for stdout handlers to be registered before starting
  `wrangler dev`
- Ignores errors if we failed to find a proccess to kill
  (assumes the process was already killed)

* fix: throw `UserError`s for R2 object/bucket not-found errors

These errors should not be reported to Sentry.

* global install

* Ensure internal workers listen on ipv4 only

* shorter timeouts


---------

Co-authored-by: Samuel Macleod <[email protected]>

* Python support (#4901)

* Implements wrangler deploy/dev support for Python.

* Migrate to `--no-bundle` approach

* Basic support for `requirements.txt`

* address review comments

* Strip package versions

* Support deploying

* Address comments

* Fix tests

---------

Co-authored-by: Dominik Picheta <[email protected]>

* Version Packages (#4891)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [C3] Add `getBindingsProxy` support to qwik template (#4927)

* Split package.json update into multiple phases

* Add getBindingsProxy to qwik template

* Add support for testing dev scripts in c3 e2e tests

* Refactor framework e2e verification helpers

* Add support for verifying build script in framework e2es

* Refactor e2e helpers

* Refactor workers e2e tests to re-align with frameworks tests

* Refactor RunnerConfig in e2e tests

* Fixing cli e2e tests

* changeset

* remove leftover test value

* Fix issue with npm tests & fix e2e logging

* Addressing PR feedback

* [playground-preview-worker] fix: don't report invalid upload input (#4937)

* fix: don't report invalid `edge-preview-authenticated-proxy` URLs (#4939)

* [D1] print wrangler banner at the start of every D1 command (#4938)

* fix: make the entrypoint optional for the `types` command (#4931)

---------

Co-authored-by: MrBBot <[email protected]>

* add a `cf` field to the `getBindingsProxy` result (#4926)


---------

Co-authored-by: James Culveyhouse <[email protected]>

* Improve DX with `node:*` modules (#4499)

* Turn node build failures into warnings

* Allow files to suppress warnings for specific modules

* Remove comment-based allow-listing

* Add changeset

* Update .changeset/chatty-balloons-impress.md

Co-authored-by: James M Snell <[email protected]>

* Pass through `defineNavigatorUserAgent`

* Add tests

* lockfile

* Linting

* fix tests

---------

Co-authored-by: James M Snell <[email protected]>

* improve(r2): Update Sippy endpoint request payloads to match new schema (#4928)

* fix(r2): update Sippy API request payloads

* improve(r2): rename sippy flags for clarity

* improve(r2): stricter existence in Sippy

* [C3] Bump create-qwik from 1.4.3 to 1.4.4 in /packages/create-cloudflare/src/frameworks (#4935)

* [C3] Bump create-qwik in /packages/create-cloudflare/src/frameworks

Bumps [create-qwik](https://github.com/BuilderIO/qwik/tree/HEAD/packages/create-qwik) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/BuilderIO/qwik/releases)
- [Commits](https://github.com/BuilderIO/qwik/commits/v1.4.4/packages/create-qwik)

---
updated-dependencies:
- dependency-name: create-qwik
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>

* fix: allow `port` option to be specified with `unstable_dev()` (#4953)

* Extend error handling of proxy request errors in ProxyWorker (#4867)

* ignore stale proxy errors

* attempt to recover from ProxyWorker fetch errors
by requeuing the request (only if it is GET or HEAD)

* add test

* add changeset

* refactor to flatten nested if-else blocks

* requeue request for retry at front of queue

* sort batch of requests in queue by order of arrival

* Revert "sort batch of requests in queue by order of arrival"

This reverts commit 3329f19.

* Revert "requeue request for retry at front of queue"

This reverts commit f0377b7.

* prioritise requests being retried
over requests being proxied for the first time

* better comments

* update changeset to match recommeded format

* Update five-cooks-share.md (#4956)

* Version Packages (#4934)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Pete Bacon Darwin <[email protected]>
Co-authored-by: Dario Piotrowicz <[email protected]>
Co-authored-by: James Culveyhouse <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>
Co-authored-by: petero-dk <[email protected]>
Co-authored-by: Dominik Picheta <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Peter Wu <[email protected]>
Co-authored-by: Taylor Smith <[email protected]>
Co-authored-by: Peter Bacon Darwin <[email protected]>
Co-authored-by: Magnus Dahlstrand <[email protected]>
Co-authored-by: Max Rozen <[email protected]>
Co-authored-by: Nora Söderlund <[email protected]>
Co-authored-by: Samuel Macleod <[email protected]>
Co-authored-by: Dominik Picheta <[email protected]>
Co-authored-by: James M Snell <[email protected]>
Co-authored-by: Siddhant <[email protected]>
Co-authored-by: Rahul Sethi <[email protected]>
@kika
Copy link

kika commented Jul 14, 2024

Are you considering issues for reopening or it's better to file a new one?

This issue is not fixed if being used together with workaround for the issue #3676
The first run of sudo wrangler pages dev --port 443 --live-reload works fine, but after rebuild and reload it bails out with the same unhandled exception as in #3676

@petebacondarwin
Copy link
Contributor

Please create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working pages Relating to Pages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants