[wrangler] fix: listen on loopback for wrangler dev port check and login

[Lekensteyn]

The wrangler dev port availability check triggers a firewall prompt on macOS while it briefly opens and closes listeners. The OAuth callback server from wrangler login has the same issue.

Fix both cases by listening on the loopback address only by default.

Fixed some new test failures by using locally available IP addresses:

wrangler:test:   ● wrangler dev › ip › should use to `ip` from `wrangler.toml`, if available
wrangler:test:     listen EADDRNOTAVAIL: address not available 1.2.3.4:8787
wrangler:test:
wrangler:test:   ● wrangler dev › ip › should use --ip command line arg, if provided
wrangler:test:     listen EADDRNOTAVAIL: address not available 5.6.7.8:8787

Relates to #4430

---

Note: the test suite still has many problems with listening on the wildcard address, for example fixtures/pages-ws-app/server/index.ts. Find more issues with: git grep -ne '\.listen('

What this PR solves / how to test:

Run wrangler dev, wrangler dev --remote, and wrangler login. Both should not trip a macOS "Accept incoming connections" firewall dialog. The wrangler dev --remote --ip "*" option should continue to work.

While wrangler dev has a shortlived socket, wrangler login listens for some more time. You can check this with lsof -nPiTCP -sTCP:LISTEN on macOS or ss -tlpn on Linux.

Author has addressed the following:

• Tests
  • Included
  • Not necessary because: non-critical functionality.
• Changeset (Changeset guidelines)
  • Included
  • Not necessary because:
• Associated docs
  • Issue(s)/PR(s):
  • Not necessary because: bugfix.

[changeset-bot]

🦋 Changeset detected

Latest commit: 4e711c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7733932220/npm-package-wrangler-4830

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4830/npm-package-wrangler-4830

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7733932220/npm-package-wrangler-4830 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7733932220/npm-package-create-cloudflare-4830 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7733932220/npm-package-miniflare-4830

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7733932220/npm-package-cloudflare-pages-shared-4830

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20240129.0
workerd	1.20240129.0	1.20240129.0
workerd --version	1.20240129.0	2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a94d46f) 70.64% compared to head (4e711c9) 70.66%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4830      +/-   ##
==========================================
+ Coverage   70.64%   70.66%   +0.01%     
==========================================
  Files         292      292              
  Lines       15178    15183       +5     
  Branches     3860     3863       +3     
==========================================
+ Hits        10723    10729       +6     
+ Misses       4455     4454       -1     

Files	Coverage Δ
packages/wrangler/src/dev.tsx	81.56% <100.00%> (+0.21%)	⬆️
packages/wrangler/src/user/user.ts	72.67% <100.00%> (ø)
packages/wrangler/src/dev/proxy.ts	4.11% <0.00%> (-0.04%)	⬇️

... and 5 files with indirect coverage changes

[Lekensteyn]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7643938711/npm-package-wrangler-4830

While wrangler login is fixed with this prerelease, wrangler dev somehow still triggers the macOS dialog. Investigating.

[Lekensteyn]

Weird, something is still listening on the wildcard:

[pid   709] execve("/usr/local/bin/node", ["/usr/local/bin/node", "--no-warnings", "--experimental-vm-modules", "/v/linux/node_modules/wrangler/w"..., "dev"], 0x6a0dff0 /* 13 vars */) = 0
...
[pid   709] bind(31, {sa_family=AF_INET6, sin6_port=htons(8787), sin6_flowinfo=htonl(0), inet_pton(AF_INET6, "::", &sin6_addr), sin6_scope_id=0}, 28) = 0
[pid   709] bind(32, {sa_family=AF_INET, sin_port=htons(8787), sin_addr=inet_addr("0.0.0.0")}, 16) = 0
[pid   709] bind(32, {sa_family=AF_INET, sin_port=htons(8787), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid   709] bind(32, {sa_family=AF_INET, sin_port=htons(8787), sin_addr=inet_addr("172.17.0.2")}, 16) = 0
...
[pid   709] bind(32, {sa_family=AF_INET, sin_port=htons(9229), sin_addr=inet_addr("0.0.0.0")}, 16) = 0
[pid   709] bind(32, {sa_family=AF_INET, sin_port=htons(9229), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid   709] bind(32, {sa_family=AF_INET, sin_port=htons(9229), sin_addr=inet_addr("172.17.0.2")}, 16) = 0

This was run from a Docker container.

Fuller output:

node@e19694e52a33:/v$ strace -fe bind,execve --quiet=attach --signal='!SIGURG' linux/node_modules/.bin/wrangler dev
...
[pid   709] execve("/usr/local/bin/node", ["/usr/local/bin/node", "--no-warnings", "--experimental-vm-modules", "/v/linux/node_modules/wrangler/w"..., "dev"], 0x6a0dff0 /* 13 vars */) = 0
 ⛅️ wrangler 0.0.0-2af5ddc4 (update available 0.0.0-f4f38fc7)
-----------------------------------------------------------------------
[pid   721] execve("/v/linux/node_modules/@esbuild/linux-x64/bin/esbuild", ["/v/linux/node_modules/@esbuild/l"..., "--service=0.17.19", "--ping"], 0x67c1610 /* 11 vars */) = 0
[pid   709] bind(31, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid   709] bind(31, {sa_family=AF_INET6, sin6_port=htons(8787), sin6_flowinfo=htonl(0), inet_pton(AF_INET6, "::", &sin6_addr), sin6_scope_id=0}, 28) = 0
[pid   709] bind(32, {sa_family=AF_INET, sin_port=htons(8787), sin_addr=inet_addr("0.0.0.0")}, 16) = 0
[pid   709] bind(32, {sa_family=AF_INET, sin_port=htons(8787), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid   709] bind(32, {sa_family=AF_INET, sin_port=htons(8787), sin_addr=inet_addr("172.17.0.2")}, 16) = 0
[pid   709] bind(32, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid   709] bind(32, {sa_family=AF_INET6, sin6_port=htons(9229), sin6_flowinfo=htonl(0), inet_pton(AF_INET6, "::", &sin6_addr), sin6_scope_id=0}, 28) = 0
[pid   709] bind(32, {sa_family=AF_INET, sin_port=htons(9229), sin_addr=inet_addr("0.0.0.0")}, 16) = 0
[pid   709] bind(32, {sa_family=AF_INET, sin_port=htons(9229), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid   709] bind(32, {sa_family=AF_INET, sin_port=htons(9229), sin_addr=inet_addr("172.17.0.2")}, 16) = 0
[pid   709] bind(32, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid   709] bind(32, {sa_family=AF_INET6, sin6_port=htons(0), sin6_flowinfo=htonl(0), inet_pton(AF_INET6, "::", &sin6_addr), sin6_scope_id=0}, 28) = 0
╭────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [b] open a browser, [d] open Devtools, [l] turn off local mode, [c] clear console, [x] to exit                                                                                                                                             │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
[pid   727] bind(32, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid   709] bind(33, {sa_family=AF_INET, sin_port=htons(6284), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid   709] bind(33, {sa_family=AF_INET, sin_port=htons(6284), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
⎔ Starting local server...
╭────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [b] open a browser, [d] open Devtools, [l] turn off local mode, [c] clear console, [x] to exit                                                                                                                                             │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
[pid   709] bind(32, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid   751] bind(9, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid   752] execve("/v/linux/node_modules/@cloudflare/workerd-linux-64/bin/workerd", ["/v/linux/node_modules/@cloudflar"..., "serve", "--binary", "--experimental", "--socket-addr=entry=127.0.0.1:0", "--external-addr=loopback=localho"..., "--control-fd=3", "-", "--inspector-addr=localhost:45461"], 0x693f6a0 /* 12 vars */ <unfinished ...>
[pid   751] +++ exited with 0 +++
[pid   752] <... execve resumed>)       = 0
[pid   765] bind(11, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid   765] +++ exited with 0 +++
[pid   764] bind(11, {sa_family=AF_INET, sin_port=htons(45461), sin_addr=inet_addr("127.0.0.1")}, 16 <unfinished ...>
[pid   766] bind(9, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12 <unfinished ...>
[pid   764] <... bind resumed>)         = 0
[pid   766] <... bind resumed>)         = 0
[wrangler:inf] Ready on http://localhost:8787

Looks like it has something to do with usage of get-port which seems to probe all local interfaces... pretty unnecessary. Working on a fix for that.

[Lekensteyn]

I tested with wrangler dev, it correctly skipped listening on multiple interfaces and instead checked 127.0.0.1 only.

However, with --ip 0.0.0.0, the getPort check still checks 127.0.0.1. So somehow --ip did not make it tothe config.dev.ip variable. Given that's the case, I will make the host fixed I guess.

strace with host option to getPort

node@e19694e52a33:/v$ strace -fe bind,execve --quiet=attach --signal='!SIGURG' linux2/node_modules/.bin/wrangler dev --ip 0.0.0.0
...
[pid  1268] execve("/usr/local/bin/node", ["/usr/local/bin/node", "--no-warnings", "--experimental-vm-modules", "/v/linux2/node_modules/wrangler/"..., "dev", "--ip", "0.0.0.0"], 0x60650f0 /* 13 vars */) = 0
 ⛅️ wrangler 0.0.0-de7507b0 (update available 0.0.0-f4f38fc7)
-----------------------------------------------------------------------
[pid  1280] execve("/v/linux2/node_modules/@esbuild/linux-x64/bin/esbuild", ["/v/linux2/node_modules/@esbuild/"..., "--service=0.17.19", "--ping"], 0x6a41430 /* 11 vars */) = 0
[pid  1268] bind(31, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1287] bind(32, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1268] bind(32, {sa_family=AF_INET, sin_port=htons(8787), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid  1268] bind(32, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1288] bind(32, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1268] bind(32, {sa_family=AF_INET, sin_port=htons(9229), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid  1268] bind(32, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1289] bind(32, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1268] bind(32, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [b] open a browser, [d] open Devtools, [l] turn off local mode, [c] clear console, [x] to exit                                                                                        │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
[pid  1268] bind(32, {sa_family=AF_INET, sin_port=htons(6284), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid  1268] bind(33, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("0.0.0.0")}, 16) = 0
⎔ Starting local server...
╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [b] open a browser, [d] open Devtools, [l] turn off local mode, [c] clear console, [x] to exit                                                                                        │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
[pid  1268] bind(32, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid  1305] bind(9, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1305] +++ exited with 0 +++
[pid  1306] execve("/v/linux2/node_modules/@cloudflare/workerd-linux-64/bin/workerd", ["/v/linux2/node_modules/@cloudfla"..., "serve", "--binary", "--experimental", "--socket-addr=entry=127.0.0.1:0", "--external-addr=loopback=localho"..., "--control-fd=3", "-", "--inspector-addr=localhost:45425"], 0x6b99430 /* 12 vars */) = 0
[pid  1319] bind(11, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1292] bind(9, {sa_family=AF_INET, sin_port=htons(8787), sin_addr=inet_addr("0.0.0.0")}, 16) = 0
[wrangler:inf] Ready on http://0.0.0.0:8787
╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
[wrangler:inf] - http://127.0.0.1:8787
[wrangler:inf] - http://172.17.0.2:8787

[Lekensteyn]

The strace for the final version that also prevents the macOS firewall dialog via getPort.

strace wrangler dev --ip 0.0.0.0

node@e19694e52a33:/v$ strace -fe bind,execve --quiet=attach --signal='!SIGURG' linux3/node_modules/.bin/wrangler dev --ip 0.0.0.0
...
[pid  1459] execve("/usr/local/bin/node", ["/usr/local/bin/node", "--no-warnings", "--experimental-vm-modules", "/v/linux3/node_modules/wrangler/"..., "dev", "--ip", "0.0.0.0"], 0x7b510f0 /* 13 vars */) = 0
 ⛅️ wrangler 0.0.0-5d8e95ba (update available 0.0.0-f4f38fc7)
-----------------------------------------------------------------------
[pid  1471] execve("/v/linux3/node_modules/@esbuild/linux-x64/bin/esbuild", ["/v/linux3/node_modules/@esbuild/"..., "--service=0.17.19", "--ping"], 0x6591430 /* 11 vars */) = 0
[pid  1459] bind(31, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1478] bind(32, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1459] bind(32, {sa_family=AF_INET, sin_port=htons(8787), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid  1459] bind(32, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1479] bind(32, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1459] bind(32, {sa_family=AF_INET, sin_port=htons(9229), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid  1459] bind(32, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1480] bind(32, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1459] bind(32, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [b] open a browser, [d] open Devtools, [l] turn off local mode, [c] clear console, [x] to exit                                                                                        │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
[pid  1459] bind(32, {sa_family=AF_INET, sin_port=htons(6284), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid  1459] bind(33, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("0.0.0.0")}, 16) = 0
⎔ Starting local server...
╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [b] open a browser, [d] open Devtools, [l] turn off local mode, [c] clear console, [x] to exit                                                                                        │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
[pid  1459] bind(32, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid  1497] bind(9, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1498] execve("/v/linux3/node_modules/@cloudflare/workerd-linux-64/bin/workerd", ["/v/linux3/node_modules/@cloudfla"..., "serve", "--binary", "--experimental", "--socket-addr=entry=127.0.0.1:0", "--external-addr=loopback=localho"..., "--control-fd=3", "-", "--inspector-addr=localhost:41761"], 0x66e8870 /* 12 vars */ <unfinished ...>
[pid  1497] +++ exited with 0 +++
[pid  1498] <... execve resumed>)       = 0
[pid  1511] bind(11, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[wrangler:inf] Ready on http://0.0.0.0:8787
[pid  1510] bind(11, {sa_family=AF_INET, sin_port=htons(41761), sin_addr=inet_addr("127.0.0.1")}, 16╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [b] open a browser, [d] open Devtools, [l] turn off local mode, [c] clear console, [x] to exit                                                                                        │
[wrangler:inf] - http://127.0.0.1:8787
[wrangler:inf] - http://172.17.0.2:8787
╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [b] open a browser, [d] open Devtools, [l] turn off local mode, [c] clear console, [x] to exit                                                                                        │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
[pid  1514] bind(13, {sa_family=AF_NETLINK, nl_pid=0, nl_groups=00000000}, 12) = 0
[pid  1514] +++ exited with 0 +++
[pid  1498] bind(13, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
[pid  1459] bind(55, {sa_family=AF_INET, sin_port=htons(6284), sin_addr=inet_addr("127.0.0.1")}, 16) = -1 EADDRINUSE (Address already in use)

Tested on macOS:

$ npm install --prefix prefix3 https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7647709387/npm-package-wrangler-4830
$ prefix3/node_modules/.bin/wrangler dev
 ⛅️ wrangler 0.0.0-5d8e95ba (update available 0.0.0-f4f38fc7)
-----------------------------------------------------------------------
⎔ Starting local server...
[wrangler:inf] Ready on http://localhost:8787
╭──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [b] open a browser, [d] open Devtools, [l] turn off local mode, [c] clear console, [x] to exit                               │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

[thibmeu]

code looks good to me, with a possible readability improvement

[mrbbot]

Looks good to me, tested locally using wrangler login and wrangler dev from the pre-release. Both commands work and don't display any firewall prompts. 👍

[Lekensteyn]

I am not sure how I can trigger this code path as making wrangler dev --remote --ip "*" work also needed this check in packages/wrangler/src/dev.tsx.

Based on the following existing code, I added the explicit check for * here just in case:

workers-sdk/packages/wrangler/src/dev/proxy.ts

Line 169 in 749fa3c

if (ip === "::" || ip === "*" || ip === "0.0.0.0") {

[Lekensteyn]

These tests are failing:

    ● wrangler dev › ip › should use to `ip` from `wrangler.toml`, if available

      listen EADDRNOTAVAIL: address not available 1.2.3.4:8787

    ● wrangler dev › ip › should use --ip command line arg, if provided

      listen EADDRNOTAVAIL: address not available 5.6.7.8:8787

Due to listening on non-existing addresses:

workers-sdk/packages/wrangler/src/__tests__/dev.test.tsx

Lines 878 to 906 in 749fa3c

	it("should use to `ip` from `wrangler.toml`, if available", async () => {
	writeWranglerToml({
	main: "index.js",
	dev: {
	ip: "1.2.3.4",
	},
	});
	fs.writeFileSync("index.js", `export default {};`);
	await runWrangler("dev");
	expect((Dev as jest.Mock).mock.calls[0][0].initialIp).toEqual("1.2.3.4");
	expect(std.out).toMatchInlineSnapshot(`""`);
	expect(std.warn).toMatchInlineSnapshot(`""`);
	expect(std.err).toMatchInlineSnapshot(`""`);
	});
	it("should use --ip command line arg, if provided", async () => {
	writeWranglerToml({
	main: "index.js",
	dev: {
	ip: "1.2.3.4",
	},
	});
	fs.writeFileSync("index.js", `export default {};`);
	await runWrangler("dev --ip=5.6.7.8");
	expect((Dev as jest.Mock).mock.calls[0][0].initialIp).toEqual("5.6.7.8");
	expect(std.out).toMatchInlineSnapshot(`""`);
	expect(std.warn).toMatchInlineSnapshot(`""`);
	expect(std.err).toMatchInlineSnapshot(`""`);
	});

Would you be okay with me changing the addresses from 1.2.3.4 and 5.6.7.8 to 0.0.0.0 and :: respectively? Or maybe even a *. Alternatively I need to mock the listen port check. Other ideas are welcome!

[petebacondarwin]

Using 0.0.0.0 and/or :: explicitly in these tests seems good enough.

[Lekensteyn]

Managed to get a local test environment running to avoid continously pushing to GitHub. I ran into a new test issue, filed as #4889.

Updated the patch to use 127.0.0.1 and ::1 in tests. Ready for final review! (Edit: one formatting fix, forgot to run prettier on the test file.)

Confirmed that the macOS firewall issue remains fixed with the latest version:

$ npm install --prefix prefix2 https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7733868721/npm-package-wrangler-4830
$ prefix2/node_modules/.bin/wrangler dev
 ⛅️ wrangler 0.0.0-64d2a018 (update available 0.0.0-300d427c)
-----------------------------------------------------------------------
⎔ Starting local server...
[wrangler:inf] Ready on http://localhost:8787

$ prefix2/node_modules/.bin/wrangler login
 ⛅️ wrangler 0.0.0-64d2a018 (update available 0.0.0-300d427c)
-----------------------------------------------------------------------
Attempting to login via OAuth...
Opening a link in your default browser: https://dash.cloudflare.com/oauth2/auth?<snip>

[petebacondarwin]

Great! Thanks @Lekensteyn.

[petebacondarwin]

NIT - this can also be:

Suggested change

	portValue = portValue ?? (await getPort({ port: defaultPort, host: host }));
	portValue = portValue ?? (await getPort({ port: defaultPort, host }));