chore(wrangler): update unenv dependency version #7541

vicb · 2024-12-13T13:21:03Z

Update unenv to the latest release.

unenv now resolves aliases to absolute path so the plugin does not it to do it any more.

/cc @petebacondarwin @pi0

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because: tested by existing tests
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: no user facing change

This is part 1 of 2 in a stack made with GitButler:

changeset-bot · 2024-12-13T13:21:08Z

🦋 Changeset detected

Latest commit: 7913462

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-12-13T13:27:24Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12367522688/npm-package-wrangler-7541

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7541/npm-package-wrangler-7541

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12367522688/npm-package-wrangler-7541 dev path/to/script.js

Additional artifacts:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12367522688/npm-package-cloudflare-workers-bindings-extension-7541 -O ./cloudflare-workers-bindings-extension.0.0.0-v859e5119b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v859e5119b.vsix

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12367522688/npm-package-create-cloudflare-7541 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12367522688/npm-package-cloudflare-kv-asset-handler-7541

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12367522688/npm-package-miniflare-7541

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12367522688/npm-package-cloudflare-pages-shared-7541

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12367522688/npm-package-cloudflare-vitest-pool-workers-7541

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12367522688/npm-package-cloudflare-workers-editor-shared-7541

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12367522688/npm-package-cloudflare-workers-shared-7541

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12367522688/npm-package-cloudflare-workflows-shared-7541

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20241205.0
`workerd`	1.20241205.0	1.20241205.0
`workerd --version`	1.20241205.0	2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

vicb · 2024-12-13T14:43:18Z

packages/wrangler/src/__tests__/deploy.test.ts

@@ -10090,7 +10090,7 @@ export default{
 			}
 		`);
 			expect(fs.readFileSync("dist/index.js", { encoding: "utf-8" })).toContain(
-				`import path from "path";`
+				`import path from "node:path";`


This change is required because unenv module resolution will always append the node: prefix

vicb · 2024-12-13T14:44:09Z

packages/wrangler/src/__tests__/deploy.test.ts

@@ -10069,7 +10069,7 @@ export default{
 			fs.writeFileSync(
 				"index.js",
 				`
-      import path from 'path';
+      import path from 'node:path';


This change is not required - the output is the same with or without the prefix.
Added only for consistency with l10093 below

packages/wrangler/src/deployment-bundle/esbuild-plugins/hybrid-nodejs-compat.ts

pi0 · 2024-12-13T18:01:49Z

packages/wrangler/src/deployment-bundle/esbuild-plugins/hybrid-nodejs-compat.ts

 		// Convert `require()` calls for NPM packages to a virtual ES Module that can be imported avoiding the require calls.
 		// Note: Does not apply to Node.js packages that are handled in `handleRequireCallsToNodeJSBuiltins`
 		if (
 			args.kind === "require-call" &&
-			(unresolvedAlias.startsWith("unenv/runtime/npm/") ||
-				unresolvedAlias.startsWith("unenv/runtime/mock/"))
+			(unresolved.startsWith("unenv/runtime/npm/") ||


I recommend using resolveAlias from pathe/utils (pathe is safe against windows paths when comparing and also handles multiple recursive aliases a => b => c)

Not sure to understand how it would help here?
"unenv/runtime/npm/" comes from the preset alias.

petebacondarwin · 2024-12-16T10:31:19Z

unenv now resolves aliases to absolute path so the plugin does not it to do it any more.

🎉

packages/wrangler/src/deployment-bundle/esbuild-plugins/hybrid-nodejs-compat.ts

This reverts commit ca9410a.

* Revert "feat: add support for custom unenv resolve path (#7522)" This reverts commit 6403e41. * Create thick-ties-glow.md * Revert "chore(wrangler): update unenv dependency version (#7541)" This reverts commit ca9410a. * fix lockfile

vicb requested a review from a team as a code owner December 13, 2024 13:21

vicb added the e2e Run e2e tests on a PR label Dec 13, 2024

vicb force-pushed the unenv-up branch from 83c0a72 to 60518ee Compare December 13, 2024 13:22

vicb requested a review from petebacondarwin December 13, 2024 13:22

vicb force-pushed the unenv-up branch from 60518ee to 25760cf Compare December 13, 2024 14:42

vicb commented Dec 13, 2024

View reviewed changes

pi0 reviewed Dec 13, 2024

View reviewed changes

packages/wrangler/src/deployment-bundle/esbuild-plugins/hybrid-nodejs-compat.ts Show resolved Hide resolved

pi0 reviewed Dec 13, 2024

View reviewed changes

vicb force-pushed the unenv-up branch from 25760cf to f11b747 Compare December 15, 2024 07:44

petebacondarwin approved these changes Dec 16, 2024

View reviewed changes

packages/wrangler/src/deployment-bundle/esbuild-plugins/hybrid-nodejs-compat.ts Show resolved Hide resolved

packages/wrangler/src/deployment-bundle/esbuild-plugins/hybrid-nodejs-compat.ts Show resolved Hide resolved

vicb force-pushed the unenv-up branch from f11b747 to 7913462 Compare December 16, 2024 12:49

vicb mentioned this pull request Dec 16, 2024

chore(wrangler): update unenv dependency version #7566

Closed

9 tasks

vicb added 2 commits December 17, 2024 07:20

chore(wrangler): update unenv dependency version

75774e9

fixup! fix test

a1b4438

vicb force-pushed the unenv-up branch from 7913462 to a1b4438 Compare December 17, 2024 06:20

vicb merged commit ca9410a into main Dec 17, 2024
31 checks passed

vicb deleted the unenv-up branch December 17, 2024 07:10

workers-devprod mentioned this pull request Dec 17, 2024

Version Packages #7567

Merged

penalosa added a commit that referenced this pull request Dec 18, 2024

Revert "chore(wrangler): update unenv dependency version (#7541)"

500af08

This reverts commit ca9410a.

vicb mentioned this pull request Dec 23, 2024

feat(wrangler): use unenv bulitin dependency resolution #7625

Open

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(wrangler): update unenv dependency version #7541

chore(wrangler): update unenv dependency version #7541

vicb commented Dec 13, 2024 •

edited

Loading

changeset-bot bot commented Dec 13, 2024 •

edited

Loading

github-actions bot commented Dec 13, 2024 •

edited

Loading

vicb Dec 13, 2024 •

edited

Loading

vicb Dec 13, 2024

pi0 Dec 13, 2024

vicb Dec 14, 2024

petebacondarwin commented Dec 16, 2024

chore(wrangler): update unenv dependency version #7541

chore(wrangler): update unenv dependency version #7541

Conversation

vicb commented Dec 13, 2024 • edited Loading

changeset-bot bot commented Dec 13, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Dec 13, 2024 • edited Loading

vicb Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

vicb Dec 13, 2024

Choose a reason for hiding this comment

pi0 Dec 13, 2024

Choose a reason for hiding this comment

vicb Dec 14, 2024

Choose a reason for hiding this comment

petebacondarwin commented Dec 16, 2024

vicb commented Dec 13, 2024 •

edited

Loading

changeset-bot bot commented Dec 13, 2024 •

edited

Loading

github-actions bot commented Dec 13, 2024 •

edited

Loading

vicb Dec 13, 2024 •

edited

Loading