-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat: add support for custom unenv resolve path" #7583
Conversation
This reverts commit 6403e41.
🦋 Changeset detectedLatest commit: 8a8178a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12395886295/npm-package-wrangler-7583 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7583/npm-package-wrangler-7583 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12395886295/npm-package-wrangler-7583 dev path/to/script.js Additional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12395886295/npm-package-cloudflare-workers-bindings-extension-7583 -O ./cloudflare-workers-bindings-extension.0.0.0-v805c0e2a5.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v805c0e2a5.vsix npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12395886295/npm-package-create-cloudflare-7583 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12395886295/npm-package-cloudflare-kv-asset-handler-7583 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12395886295/npm-package-miniflare-7583 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12395886295/npm-package-cloudflare-pages-shared-7583 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12395886295/npm-package-cloudflare-unenv-preset-7583 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12395886295/npm-package-cloudflare-vitest-pool-workers-7583 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12395886295/npm-package-cloudflare-workers-editor-shared-7583 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12395886295/npm-package-cloudflare-workers-shared-7583 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12395886295/npm-package-cloudflare-workflows-shared-7583 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
This reverts commit ca9410a.
df2b960
to
8a8178a
Compare
@penalosa and I have both tested with this pre-release version and can confirm the revert fixes the issue. Will go ahead and merge |
Many thanks @penalosa for handling the revert of something I broke :( FYI @pi0 has fixed the root cause in unenv - it is linked to package resolution and the fact that I'll resubmit the PRs and make sure I test the pre-release version locally. 🙏 |
I think we need to go further and add tests (probably to nodejs-hybrid fixture) that will prevent this regression. |
Reverts #7522
This should resolve #7577, and fix the C3 E2E failures we're seeing, which seem to be due to a failure to resolve unenv properly