Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Docker login to Github bulid-and-push job #5

Merged
merged 19 commits into from
Sep 9, 2020
Merged

Conversation

danjbh
Copy link
Contributor

@danjbh danjbh commented Sep 8, 2020

what & why?

  • Adding Docker login step to build-and-push job since it's currently borked

references

docker/build-push-action#88 (comment)

osterman
osterman previously approved these changes Sep 9, 2020
@danjbh
Copy link
Contributor Author

danjbh commented Sep 9, 2020

Alright @osterman , it took a bit of tinkering to get the rest of the steps sorted out, but it's in a working state at this point, as far as I can tell at least.

Definitely have a look at the Prep step in bash logic to see if you think we need any tweaks there. I tried to mirror what I think how the previous tagging was working at least.

Let me know!

@danjbh danjbh merged commit d194dd9 into master Sep 9, 2020
@danjbh danjbh deleted the fix-docker-login branch September 9, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants