Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Docker login to Github bulid-and-push job #5

Merged
merged 19 commits into from
Sep 9, 2020
Merged

Adding Docker login to Github bulid-and-push job #5

Changes from 7 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e011cc2
Adding Dockerhub login to build-and-push job
danjbh Sep 8, 2020
b424b02
Removing conditional around Docker login
danjbh Sep 8, 2020
9049848
Revert "Removing conditional around Docker login"
danjbh Sep 8, 2020
7c66a5c
Update .github/workflows/docker.yml
danjbh Sep 9, 2020
d3fbc84
Update .github/workflows/docker.yml
danjbh Sep 9, 2020
32fd695
Fixing workflow issue
danjbh Sep 9, 2020
732bf93
Fixing credentials
danjbh Sep 9, 2020
ea4a752
Setting build-and-push action back down to v1
danjbh Sep 9, 2020
9a293f0
Adding first draft of tagging step to build-and-push jbo
danjbh Sep 9, 2020
0c4f969
Tweaking tag logic
danjbh Sep 9, 2020
796870c
Trying a thing
danjbh Sep 9, 2020
a548651
Fixing some things..
danjbh Sep 9, 2020
d813ada
Testing something
danjbh Sep 9, 2020
727132a
Removing unsupported options
danjbh Sep 9, 2020
ffa7a45
Let's try this again...
danjbh Sep 9, 2020
1577c1f
Fixing PR number
danjbh Sep 9, 2020
db78352
Removing QEMU step
danjbh Sep 9, 2020
c619121
Slight tweak to version thing
danjbh Sep 9, 2020
bce16ea
Apply suggestions from code review
osterman Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,17 @@ jobs:
steps:
- name: "Checkout source code at current commit"
uses: actions/checkout@v2
- name: "Build and push docker image to DockerHub"
uses: docker/build-push-action@v2
- name: Login to DockerHub
if: github.event.pull_request.head.repo.full_name == github.repository
uses: docker/login-action@v1
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}
- name: "Build and push docker image to DockerHub"
uses: docker/build-push-action@v2
danjbh marked this conversation as resolved.
Show resolved Hide resolved
with:
repository: ${{ github.repository }}
registry: registry-1.docker.io
tag_with_ref: true
danjbh marked this conversation as resolved.
Show resolved Hide resolved
push: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
tag_with_sha: true