v0.4.0
Fixing Docker Hub publishes @danjbh (#7)
## what?!I had originally modeled the Github action build triggers against another project, and upon further analysis, I don't think the project I modeled is actually working properly. In a nutshell, the release created
trigger wasn't firing when the auto-release
workflow was executed, which means we were never getting Docker images with actual semver tags in Docker Hub.
In addition, I had to cleanup some of the expression logic to properly match github.ref
.
Anyhow, I was able to test it in my branch before merging to master by just pushing a new tag, and I'm happy to report it's working. Here's the behavior...
- If you're pushing a new commit against a non-forked PR, it will build/push a new image to Docker hub (with both an
sha-<sha>
AND apr-<num>-merge
tag - If a new tag (or release) is created, it will build an image and upload it to Docker hub using the proper semver format (generated by
auto-release
, but without the leadingv
)
What I haven't tested is the auto-release
portion, but I'm fairly certain it should work with this method. Of course, I thought the past couple attempts would work, and I think I'm starting to question my own sanity at this point.
Updating conditional to build-and-push Github workflow @danjbh (#6)
## what & why?We need to build/publish master when triggered. The added logic triggers the steps if the branch is master
but not if it's a pull request (since the source branch in a forked repo could also be master
).
Adding Docker login to Github bulid-and-push job @danjbh (#5)
## what & why?- Adding Docker login step to build-and-push job since it's currently borked