-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[terratet] Test atmos version #56
Conversation
WalkthroughThe pull request modifies the GitHub Actions workflow file for Terraform ChatOps, specifically updating the Changes
Possibly related PRs
Suggested labels
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Important Title is necessary and should not be empty.Kindly provide a meaningful title for this Pull Request. |
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/shared-terraform-chatops.yml
(1 hunks)
🔇 Additional comments (1)
.github/workflows/shared-terraform-chatops.yml (1)
Line range hint 307-311
: Review test skip flags in the fixtures job
The go test command includes flags that skip both temporary directory creation (-cth.skip-tmp-dir
) and test execution (-cth.skip-tests
). This appears to defeat the purpose of the test step in the fixtures job.
Let's verify the impact of these flags:
Consider removing these flags unless there's a specific requirement:
- go test -v -cth.skip-tmp-dir -cth.skip-tests
+ go test -v
@@ -304,6 +304,7 @@ jobs: | |||
- name: "Create fixtures" | |||
id: fixtures | |||
run: |- | |||
atmos version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Capture and validate the atmos version output
While adding the atmos version
check aligns with the PR objective, the output should be captured and validated to ensure the correct version is being used.
Consider modifying the command to capture and validate the version:
- atmos version
+ ATMOS_VERSION=$(atmos version)
+ echo "Atmos version: $ATMOS_VERSION"
+ if [[ ! "$ATMOS_VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
+ echo "Invalid atmos version format: $ATMOS_VERSION"
+ exit 1
+ fi
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
atmos version | |
ATMOS_VERSION=$(atmos version) | |
echo "Atmos version: $ATMOS_VERSION" | |
if [[ ! "$ATMOS_VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then | |
echo "Invalid atmos version format: $ATMOS_VERSION" | |
exit 1 | |
fi |
what
Summary by CodeRabbit