[terratest] Use atmos version pin everywhere #58
Conversation
WalkthroughThe pull request modifies the GitHub Actions workflow file for shared Terraform ChatOps by introducing a centralized Changes
Possibly related PRs
Suggested labels
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Important Title is necessary and should not be empty.Kindly provide a meaningful title for this Pull Request. |
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/shared-terraform-chatops.yml (1)
85-85: LGTM! Good practice to centralize version management.The addition of
atmos_versionas an output variable in the context job helps maintain consistency and simplifies version management across the workflow.This centralization makes it easier to update the Atmos version across all jobs in the future, reducing the risk of version mismatches.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/shared-terraform-chatops.yml(4 hunks)
🔇 Additional comments (1)
.github/workflows/shared-terraform-chatops.yml (1)
239-239: LGTM! Consistent version usage across jobs.
The atmos version is now consistently referenced from the context job's output across all jobs (fixtures, terratest, and cleanup), replacing what were likely hardcoded versions.
Let's verify that all Atmos installations use the centralized version:
Also applies to: 429-429, 638-638
✅ Verification successful
✅ Verified: All Atmos version references are consistently using the centralized version
All three occurrences of atmos-version in the workflow file are correctly using the centralized version from context job's output (${{ needs.context.outputs.atmos_version }}). No hardcoded versions were found, confirming the consistent version usage across jobs as mentioned in the review comment.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify all Atmos installations use the centralized version
# Test: Search for any hardcoded Atmos versions that might have been missed
rg "atmos-version: ['\"][\d\.]+" --type yaml
Length of output: 48
Script:
#!/bin/bash
# Let's search for all occurrences of atmos-version in yaml files to verify consistency
rg "atmos-version:" --type yaml -A 1
Length of output: 36
Script:
#!/bin/bash
# Let's try a more specific search in the workflow file mentioned in the review
cat ".github/workflows/shared-terraform-chatops.yml" | grep -A 1 "atmos-version:"
Length of output: 292
what
Summary by CodeRabbit