Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darkmode #33

Merged
merged 53 commits into from
Feb 6, 2024
Merged

Darkmode #33

merged 53 commits into from
Feb 6, 2024

Conversation

osterman
Copy link
Member

@osterman osterman commented Feb 2, 2024 •
edited
Loading

what

  • Render images for darkmode/lightmode
  • Improve checkboxes in profile page
  • Move badges to the right
  • Reduce some of our boilerplate using details blocks

why

  • Transparent images with black text do not render well in dark mode

references

@osterman osterman requested review from a team as code owners February 2, 2024 16:39
aknysh
aknysh previously approved these changes Feb 6, 2024
View reviewed changes
@osterman osterman merged commit 8a97588 into main Feb 6, 2024
4 checks passed
@osterman osterman deleted the darkmode branch February 6, 2024 19:30
@osterman osterman mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @aknysh