Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ditch reference-style links #34

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Ditch reference-style links #34

merged 7 commits into from
Feb 8, 2024

Conversation

osterman
Copy link
Member

@osterman osterman commented Feb 8, 2024

what

  • Convert most markdown links and images to raw HTML

why

  • Many reference-style links stopped working with Darkmode #33.
  • Most of the README is already in HTML, there's no benefit to sticking with Markdown format
  • README is generated, let's just generate HTML
  • Use gotempate variables as references instead

references

@osterman osterman requested review from a team as code owners February 8, 2024 17:08
@osterman osterman requested a review from a team as a code owner February 8, 2024 17:19
Nuru
Nuru reviewed Feb 8, 2024
View reviewed changes
README.md.gotmpl Outdated Show resolved Hide resolved
@Nuru Nuru self-requested a review February 8, 2024 20:16
@Nuru Nuru merged commit 2095e59 into main Feb 8, 2024
4 checks passed
@Nuru Nuru deleted the ditch-anchors branch February 8, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @Nuru