Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade S3 Log Storage module to latest version #97

Closed
wants to merge 6 commits into from

Conversation

danfsd
Copy link

@danfsd danfsd commented Apr 27, 2023

what

  • upgrades module.logs to the latest S3 Log Storage module
  • the lifecycle configuration block currently has some hardcoded values that were specified following the their respective values using the old S3 Log Storage module, which were automatically set by the module itself (not via inputs)

why

references

N/A

@danfsd danfsd requested review from a team as code owners April 27, 2023 18:11
@danfsd danfsd requested review from jamengual and woz5999 April 27, 2023 18:11
@danfsd
Copy link
Author

danfsd commented Apr 27, 2023

Okay, I'm fairly new to the Cloudposse's community, but I think the game plan should be:

  1. Release a new version of terraform-aws-s3-bucket with Sets Bucket ACL after its ownership controls were set terraform-aws-s3-bucket#177 in it
  2. Release a new version of terraform-aws-s3-log-storage pointing to the new version for terraform-aws-s3-bucket
  3. Modify this PR by pointing to the new version of terraform-aws-s3-log-storage

What do you guys think?

@danfsd
Copy link
Author

danfsd commented Apr 27, 2023

Actually, there was already an existing PR for fixing terraform-aws-s3-bucket
cloudposse/terraform-aws-s3-bucket#176

The game plan should not change and we can continue when either one of them gets merged.

@max-lobur
Copy link
Contributor

Updating in #103

@max-lobur max-lobur closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bucket cannot have ACLs set with ObjectOwnership's BucketOwnerEnforced setting
2 participants