Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: ACL depends on ownership_controls #176

Closed
wants to merge 14 commits into from
Closed

Add: ACL depends on ownership_controls #176

wants to merge 14 commits into from

Conversation

bigfantech
Copy link

@bigfantech bigfantech commented Apr 27, 2023 •
edited
Loading

what

  • aws_s3_bucket_ownership_controls is set first, followed by bucket ACL.

why

  • Starting April 2023, AWS has changed default ObjectOwnership = Bucket Owner Preferred.
    So to add ACL aws_s3_bucket_ownership_controls must be set to ObjectWriter (or) BucketOwnerPreferred first.
    In this PR, aws_s3_bucket_acl depends_on aws_s3_bucket_ownership_controls resource block.
    aws_s3_bucket_ownership_controls default set to BucketOwnerEnforced

references

@bigfantech
Add: ACL depends on ownership_controls
19c414f 
  # AWS changed default ObjectOwnership = Bucket Owner Preferred.
  # To add ACL `aws_s3_bucket_ownership_controls` must be set to `ObjectWriter` (or) `BucketOwnerPreferred`
 Ref: https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/
@bigfantech bigfantech requested review from a team as code owners April 27, 2023 09:45
bigfantech added 11 commits April 27, 2023 15:18
@bigfantech
Misc: Comment update in ACL block depends_on
e65c482
@bigfantech
Fix: } in ACL block
d8b0649
@bigfantech
Fix: PUBLIC_REPO_ACCESS_TOKEN -> REPO_ACCESS_TOKEN
0982bd2 
Incorrect secret name. secrets.REPO_ACCESS_TOKEN derived from other CloudPosse repos, example: https://github.com/cloudposse/terraform-aws-rds-cluster/blob/master/.github/workflows/auto-context.yml
@bigfantech
Undo last commit: PUBLIC_REPO_ACCESS_TOKEN
60cb459
@bigfantech
Fix: PUBLIC_REPO_ACCESS_TOKEN -> REPO_ACCESS_TOKEN
9b46856 
Actions fail with error "refusing to allow a Personal Access Token to create or update workflow `.github/workflows/auto-context.yml` without `workflow` scope"

Reason: Incorrect secret name. secrets.REPO_ACCESS_TOKEN derived from other CloudPosse repos, secret ref: https://github.com/cloudposse/terraform-aws-rds-cluster/blob/master/.github/workflows/auto-context.yml
@bigfantech
Fix: PUBLIC_REPO_ACCESS_TOKEN -> REPO_ACCESS_TOKEN
d89ce1a 
Actions fail with error "refusing to allow a Personal Access Token to create or update workflow `.github/workflows/auto-context.yml` without `workflow` scope"

Reason: Incorrect secret name. secrets.REPO_ACCESS_TOKEN derived from other CloudPosse repos, secret ref: https://github.com/cloudposse/terraform-aws-rds-cluster/blob/master/.github/workflows/auto-context.yml
@bigfantech
Fix: PUBLIC_REPO_ACCESS_TOKEN -> REPO_ACCESS_TOKEN
429c517 
Actions fail with error "refusing to allow a Personal Access Token to create or update workflow `.github/workflows/auto-context.yml` without `workflow` scope"

Reason: Incorrect secret name. secrets.REPO_ACCESS_TOKEN derived from other CloudPosse repos, secret ref: https://github.com/cloudposse/terraform-aws-rds-cluster/blob/master/.github/workflows/auto-context.yml
@bigfantech
Fix: PUBLIC_REPO_ACCESS_TOKEN -> REPO_ACCESS_TOKEN
c22cee1 
Actions fail with error "refusing to allow a Personal Access Token to create or update workflow `.github/workflows/auto-context.yml` without `workflow` scope"

Reason: Incorrect secret name. secrets.REPO_ACCESS_TOKEN derived from other CloudPosse repos, secret ref: https://github.com/cloudposse/terraform-aws-rds-cluster/blob/master/.github/workflows/auto-context.yml
@bigfantech
Fix: PUBLIC_REPO_ACCESS_TOKEN -> REPO_ACCESS_TOKEN
a5d2dc0 
Actions fail with error "refusing to allow a Personal Access Token to create or update workflow `.github/workflows/auto-context.yml` without `workflow` scope"

Reason: Incorrect secret name. secrets.REPO_ACCESS_TOKEN derived from other CloudPosse repos, secret ref: https://github.com/cloudposse/terraform-aws-rds-cluster/blob/master/.github/workflows/auto-context.yml
@bigfantech
Fix: PUBLIC_REPO_ACCESS_TOKEN -> REPO_ACCESS_TOKEN
57885d8 
Actions fail with error "refusing to allow a Personal Access Token to create or update workflow `.github/workflows/auto-context.yml` without `workflow` scope"

Reason: Incorrect secret name. secrets.REPO_ACCESS_TOKEN derived from other CloudPosse repos, secret ref: https://github.com/cloudposse/terraform-aws-rds-cluster/blob/master/.github/workflows/auto-context.yml
@bigfantech
Comment correction
aa18ce4
@bigfantech bigfantech closed this Apr 27, 2023
@bigfantech bigfantech deleted the fix/acl-objectownership-conflict branch April 27, 2023 13:13
@bigfantech bigfantech restored the fix/acl-objectownership-conflict branch April 27, 2023 13:15
@bigfantech bigfantech reopened this Apr 27, 2023
This was referenced Apr 27, 2023
Closed
Closed
@danfsd danfsd mentioned this pull request May 1, 2023
Closed
@nrmatukumalli
Copy link

Is there a timeline on merging this Pull Request ?

@Nuru Nuru mentioned this pull request May 6, 2023
Merged
@Nuru Nuru closed this in #178 May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigfantech @nrmatukumalli