Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README Snippet Use of deployment_principal_arns #172

Merged
merged 3 commits into from
Jun 28, 2021

Conversation

korenyoni
Copy link
Member

what

  • Fix use of deployment_principal_arns variable in README snippet.

why

  • The IAM Role ARN supplied in the deployment_principal_arns map is actually using S3 ARNs. This fixes the ARNs such that they are IAM Role ARNs.

references

  • N/A

@korenyoni korenyoni added patch A minor, backward compatible change documentation Improvements or additions to documentation labels Jun 28, 2021
@korenyoni korenyoni requested review from a team as code owners June 28, 2021 14:34
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found 0 infrastructure configuration error in this PR ⬇️

@korenyoni korenyoni requested a review from a team as a code owner June 28, 2021 14:35
@korenyoni korenyoni requested review from Gowiem and Benbentwo and removed request for a team June 28, 2021 14:35
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni merged commit f5169df into master Jun 28, 2021
@korenyoni korenyoni deleted the fix/readme-snippet-fix-deployment-arns branch June 28, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants